Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

allowed special character in address field #1149

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vaibhavarora102
Copy link
Contributor

Description

allowed the special characters in the address field, using RegexValidator

Fixes #1037

Type of Change:

  • Code
  • Quality Assurance

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I had tested on local setup and it works fine

Checklist:

Delete irrelevant options.

  • I have performed a self-review of my own code or materials
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@6fc528d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1149   +/-   ##
==========================================
  Coverage           ?   87.20%           
==========================================
  Files              ?       85           
  Lines              ?     4057           
  Branches           ?      237           
==========================================
  Hits               ?     3538           
  Misses             ?      448           
  Partials           ?       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fc528d...0be90ec. Read the comment docs.

Copy link
Member

@keshakaneria keshakaneria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! This looks good now 😄 good job!

@vaibhavarora102
Copy link
Contributor Author

@SanketDG can you please review

@vaibhavarora102
Copy link
Contributor Author

@keshakaneria @SanketDG
Any updates please

@vaibhavarora102
Copy link
Contributor Author

Hi any updates @isabelcosta @keshakaneria

@keshakaneria
Copy link
Member

Any updates about the review @isabelcosta?

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but we would like to see a description of how this is supposed to be tested, and could you also add a unit test @vaibhavarora102 ?
cc @keshakaneria

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Address Text field to also take special characters
3 participants