Fixed Values are not retained in forms (event, job and shift) #742

[codesankalp]

Modified post view of forms to retain the values of submitted form
when there is an error in form validation to increase users experience.

Fixes #742

Screenshots

Before submission of form:

After submission of form:

Tasks done:

• Modified form to retain values after edit
• tested the functionality.

[codecov]

Codecov Report

Merging #1131 into develop will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1131      +/-   ##
===========================================
- Coverage    87.18%   87.10%   -0.08%     
===========================================
  Files           85       85              
  Lines         4057     4080      +23     
  Branches       237      238       +1     
===========================================
+ Hits          3537     3554      +17     
- Misses         450      455       +5     
- Partials        70       71       +1     

Impacted Files	Coverage Δ
vms/event/views.py	79.61% <100.00%> (+0.29%)	⬆️
vms/shift/views.py	61.40% <0.00%> (-1.21%)	⬇️
vms/job/views.py	89.93% <0.00%> (+2.68%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0189ce8...4fc514c. Read the comment docs.

[codesankalp]

@gaurivn please review this.

[SanketDG]

just do data.get(field, '')

[codesankalp]

@SanketDG please review it again. Thanks.

[keshakaneria]

@codesankalp codecov test is failing, did you check the tests locally?

[codesankalp]

@codesankalp codecov test is failing, did you check the tests locally?

Yes, I don't know why, should I change anything @keshakaneria.

[devkapilbansal]

This may be due to the try-except block @codesankalp

[codesankalp]

@devkapilbansal in this commit I have removed the try except block inside for loop as mentioned by mentors.

[devkapilbansal]

@codesankalp you have some try except blocks in your code. Therefore you have to cover those in tests too, else find a way to reduce the numbers of try except blocks here.

One method that can be used here is .first() method. Filter your queryset instead of get and fetch the first object. Then codecov will pass

[devkapilbansal]

@codesankalp like you can change this line
city = City.objects.get(name=city_name) to city = City.objects.filter(name=city_name).first() and remove the try except block.

[codesankalp]

@devkapilbansal can you please check the build of Travis as I think the error in the build is not related to my commit.

[devkapilbansal]

@gaurivn @keshakaneria @SanketDG can you please look into the problem