Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize agent for linkchecker #2998

Merged
merged 1 commit into from Apr 18, 2024
Merged

Customize agent for linkchecker #2998

merged 1 commit into from Apr 18, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 12, 2024

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Apr 12, 2024
@germa89 germa89 added Documentation Documentation related (improving, adding, etc) CI/CD Related with CICD, Github Actions, etc labels Apr 12, 2024
@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Apr 12, 2024
@germa89 germa89 marked this pull request as ready for review April 12, 2024 09:14
@germa89 germa89 enabled auto-merge (squash) April 12, 2024 09:14
@germa89
Copy link
Collaborator Author

germa89 commented Apr 12, 2024

Checking previous linkchecker runs I see this:

(getting_started/learning: line  188) broken    https://www.ansys.com/blog/ansys-gets-into-open-source-with-github - ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
(getting_started/versioning: line   47) broken    https://www.ansys.com/it-solutions/platform-support - ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

I think this PR can fix that?? @jorgepiloto

Link: https://github.com/ansys/pymapdl/actions/runs/8586322729/job/23528685039#step:13:468

GitHub
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.14%. Comparing base (0f84c13) to head (4a44590).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
- Coverage   86.68%   84.14%   -2.54%     
==========================================
  Files          52       52              
  Lines        9497     9497              
==========================================
- Hits         8232     7991     -241     
- Misses       1265     1506     +241     

@germa89
Copy link
Collaborator Author

germa89 commented Apr 12, 2024

The codecy check is failing temporally. Not big deal.

@germa89
Copy link
Collaborator Author

germa89 commented Apr 15, 2024

Just with these changes is enough @jorgepiloto ??

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, @germa89. This should be enough.

@germa89 germa89 merged commit 78a1a16 into main Apr 18, 2024
33 of 35 checks passed
@germa89 germa89 deleted the Adding-agent-to-link-checker branch April 18, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants