Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation about remote mapdl pool #3046

Merged
merged 3 commits into from May 3, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Apr 30, 2024

As the title.

Now if we are providing a list of ports, the number of instances argument (n_instances) is optional, not needed.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the Documentation Documentation related (improving, adding, etc) label Apr 30, 2024
@germa89 germa89 requested review from clatapie and koubaa April 30, 2024 10:32
@germa89 germa89 self-assigned this Apr 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.13%. Comparing base (5442a4e) to head (81d8020).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3046      +/-   ##
==========================================
- Coverage   86.63%   84.13%   -2.51%     
==========================================
  Files          52       52              
  Lines        9498     9500       +2     
==========================================
- Hits         8229     7993     -236     
- Misses       1269     1507     +238     

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89 germa89 enabled auto-merge (squash) May 3, 2024 08:14
@germa89
Copy link
Collaborator Author

germa89 commented May 3, 2024

@pyansys-ci-bot LGTM.

Copy link
Collaborator

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 32d676b into main May 3, 2024
31 checks passed
@germa89 germa89 deleted the docs/adding-documentation-about-mapdlpool-remote branch May 3, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants