Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansys-dpf-core #3082

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update ansys-dpf-core #3082

wants to merge 1 commit into from

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented May 10, 2024

As the title.

@germa89 germa89 requested a review from a team as a code owner May 10, 2024 09:28
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89
Copy link
Collaborator Author

germa89 commented May 10, 2024

Just testing.

@github-actions github-actions bot added Maintenance General maintenance of the repo (libraries, cicd, etc) Dependencies labels May 10, 2024
@germa89
Copy link
Collaborator Author

germa89 commented May 10, 2024

Hopefully this has been addressed in the new version: ansys/pydpf-core#1438

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (dc0a56c) to head (5e0387a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3082      +/-   ##
==========================================
- Coverage   86.64%   84.16%   -2.49%     
==========================================
  Files          52       52              
  Lines        9553     9553              
==========================================
- Hits         8277     8040     -237     
- Misses       1276     1513     +237     

@germa89
Copy link
Collaborator Author

germa89 commented May 10, 2024

Still broken. @PProfizi

@germa89 germa89 marked this pull request as draft May 10, 2024 09:47
@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label May 10, 2024
@PProfizi
Copy link
Contributor

Hi @germa89,

Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC.
I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using?
I see a Docker image for 22.2 being used, isn't that a bit old?

@germa89
Copy link
Collaborator Author

germa89 commented May 13, 2024

Hi @germa89,

Looking at the error, it seems you get the error linked to the change in operator naming for NMISC and SMISC. I think you are already aware that sadly there was a breaking change on those. I just would like to understand why you would get this error here. What server version is this pipeline using? I see a Docker image for 22.2 being used, isn't that a bit old?

Hi @PProfizi

Yes, it is a bit old. But I didn't have the time to figure it out how to deploy a newer version of DPF in our CICD. I know the docker registry I'm using hasn't been updated in 2 years. I'm happy to get some guidance on how to use newer versions of DPF in our CICD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies DO NOT MERGE Not ready to be merged yet Maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants