Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form validate should keep refresh #20725

Merged
merged 2 commits into from Jan 7, 2020
Merged

fix: Form validate should keep refresh #20725

merged 2 commits into from Jan 7, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 7, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fix #20706

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Form.Item not keep error message sync when hit rule changed.
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@pr-triage pr-triage bot removed the PR: unreviewed label Jan 7, 2020
@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for ant-design ready!

Built with commit 8b342c8

https://deploy-preview-20725--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #20725 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20725      +/-   ##
==========================================
+ Coverage   97.47%   97.48%   +<.01%     
==========================================
  Files         296      296              
  Lines        6863     6869       +6     
  Branches     1905     1862      -43     
==========================================
+ Hits         6690     6696       +6     
  Misses        173      173
Impacted Files Coverage 螖
components/form/util.ts 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0ceb6cc...8b342c8. Read the comment docs.

@zombieJ zombieJ added 馃悰 Bug Ant Design Team had proved that this is a bug. and removed bug labels Jan 7, 2020
@zombieJ zombieJ merged commit 5c8cec5 into master Jan 7, 2020
@zombieJ zombieJ deleted the fix-form-validate branch January 7, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃悰 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Antd v4.0.0 forms custom validation: Incoherent errors displaying
1 participant