Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RowSelection fixed should work #20735

Merged
merged 1 commit into from Jan 7, 2020
Merged

fix: RowSelection fixed should work #20735

merged 1 commit into from Jan 7, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jan 7, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #20729

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table with rowSelection of fixed not work.
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for ant-design ready!

Built with commit 9120ebf

https://deploy-preview-20735--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #20735 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #20735      +/-   ##
==========================================
+ Coverage   97.48%   97.48%   +<.01%     
==========================================
  Files         296      296              
  Lines        6869     6870       +1     
  Branches     1862     1864       +2     
==========================================
+ Hits         6696     6697       +1     
  Misses        173      173
Impacted Files Coverage Δ
components/table/hooks/useSelection.tsx 98.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8cec5...9120ebf. Read the comment docs.

@zombieJ zombieJ merged commit 4068f3d into master Jan 7, 2020
@zombieJ zombieJ deleted the table-row-fixed branch January 7, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 Table rowSelection fixed属性不生效
1 participant