For Reviewers

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
antrea-io · Sep 22, 2021 · 7bda9a3 · 7bda9a3
1 parent 93d3f31
commit 7bda9a3
Show file tree

Hide file tree

Showing 9 changed files with 112 additions and 102 deletions.
diff --git a/build/yamls/antrea-aks.yml b/build/yamls/antrea-aks.yml
@@ -3773,9 +3773,9 @@ data:
     # this flag will not take effect.
     #  EndpointSlice: false
 
-    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless that feature gateway
-    # ServiceInternalTrafficPolicy of Kubernetes APIServer is set as enabled. If AntreaProxy is not enabled,
-    # this flag will not take effect.
+    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless the
+    # ServiceInternalTrafficPolicy feature gate of kube-apiserver is also enabled. If AntreaProxy is
+    # not enabled, this flag will not take effect.
     #  ServiceInternalTrafficPolicy: false
 
     # Enable traceflow which provides packet tracing feature to diagnose network issue.
@@ -4059,7 +4059,7 @@ metadata:
   annotations: {}
   labels:
     app: antrea
-  name: antrea-config-4k8284md8c
+  name: antrea-config-76k6dfccmh
   namespace: kube-system
 ---
 apiVersion: v1
@@ -4130,7 +4130,7 @@ spec:
             fieldRef:
               fieldPath: spec.serviceAccountName
         - name: ANTREA_CONFIG_MAP_NAME
-          value: antrea-config-4k8284md8c
+          value: antrea-config-76k6dfccmh
         image: projects.registry.vmware.com/antrea/antrea-ubuntu:latest
         imagePullPolicy: IfNotPresent
         livenessProbe:
@@ -4181,7 +4181,7 @@ spec:
         key: node-role.kubernetes.io/master
       volumes:
       - configMap:
-          name: antrea-config-4k8284md8c
+          name: antrea-config-76k6dfccmh
         name: antrea-config
       - name: antrea-controller-tls
         secret:
@@ -4462,7 +4462,7 @@ spec:
         operator: Exists
       volumes:
       - configMap:
-          name: antrea-config-4k8284md8c
+          name: antrea-config-76k6dfccmh
         name: antrea-config
       - hostPath:
           path: /etc/cni/net.d

diff --git a/build/yamls/antrea-eks.yml b/build/yamls/antrea-eks.yml
@@ -3773,9 +3773,9 @@ data:
     # this flag will not take effect.
     #  EndpointSlice: false
 
-    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless that feature gateway
-    # ServiceInternalTrafficPolicy of Kubernetes APIServer is set as enabled. If AntreaProxy is not enabled,
-    # this flag will not take effect.
+    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless the
+    # ServiceInternalTrafficPolicy feature gate of kube-apiserver is also enabled. If AntreaProxy is
+    # not enabled, this flag will not take effect.
     #  ServiceInternalTrafficPolicy: false
 
     # Enable traceflow which provides packet tracing feature to diagnose network issue.
@@ -4059,7 +4059,7 @@ metadata:
   annotations: {}
   labels:
     app: antrea
-  name: antrea-config-4k8284md8c
+  name: antrea-config-76k6dfccmh
   namespace: kube-system
 ---
 apiVersion: v1
@@ -4130,7 +4130,7 @@ spec:
             fieldRef:
               fieldPath: spec.serviceAccountName
         - name: ANTREA_CONFIG_MAP_NAME
-          value: antrea-config-4k8284md8c
+          value: antrea-config-76k6dfccmh
         image: projects.registry.vmware.com/antrea/antrea-ubuntu:latest
         imagePullPolicy: IfNotPresent
         livenessProbe:
@@ -4181,7 +4181,7 @@ spec:
         key: node-role.kubernetes.io/master
       volumes:
       - configMap:
-          name: antrea-config-4k8284md8c
+          name: antrea-config-76k6dfccmh
         name: antrea-config
       - name: antrea-controller-tls
         secret:
@@ -4464,7 +4464,7 @@ spec:
         operator: Exists
       volumes:
       - configMap:
-          name: antrea-config-4k8284md8c
+          name: antrea-config-76k6dfccmh
         name: antrea-config
       - hostPath:
           path: /etc/cni/net.d

diff --git a/build/yamls/antrea-gke.yml b/build/yamls/antrea-gke.yml
@@ -3773,9 +3773,9 @@ data:
     # this flag will not take effect.
     #  EndpointSlice: false
 
-    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless that feature gateway
-    # ServiceInternalTrafficPolicy of Kubernetes APIServer is set as enabled. If AntreaProxy is not enabled,
-    # this flag will not take effect.
+    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless the
+    # ServiceInternalTrafficPolicy feature gate of kube-apiserver is also enabled. If AntreaProxy is
+    # not enabled, this flag will not take effect.
     #  ServiceInternalTrafficPolicy: false
 
     # Enable traceflow which provides packet tracing feature to diagnose network issue.
@@ -4059,7 +4059,7 @@ metadata:
   annotations: {}
   labels:
     app: antrea
-  name: antrea-config-4g6c87t272
+  name: antrea-config-4k4k9kmfbg
   namespace: kube-system
 ---
 apiVersion: v1
@@ -4130,7 +4130,7 @@ spec:
             fieldRef:
               fieldPath: spec.serviceAccountName
         - name: ANTREA_CONFIG_MAP_NAME
-          value: antrea-config-4g6c87t272
+          value: antrea-config-4k4k9kmfbg
         image: projects.registry.vmware.com/antrea/antrea-ubuntu:latest
         imagePullPolicy: IfNotPresent
         livenessProbe:
@@ -4181,7 +4181,7 @@ spec:
         key: node-role.kubernetes.io/master
       volumes:
       - configMap:
-          name: antrea-config-4g6c87t272
+          name: antrea-config-4k4k9kmfbg
         name: antrea-config
       - name: antrea-controller-tls
         secret:
@@ -4465,7 +4465,7 @@ spec:
           path: /home/kubernetes/bin
         name: host-cni-bin
       - configMap:
-          name: antrea-config-4g6c87t272
+          name: antrea-config-4k4k9kmfbg
         name: antrea-config
       - hostPath:
           path: /etc/cni/net.d

diff --git a/build/yamls/antrea-ipsec.yml b/build/yamls/antrea-ipsec.yml
@@ -3773,9 +3773,9 @@ data:
     # this flag will not take effect.
     #  EndpointSlice: false
 
-    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless that feature gateway
-    # ServiceInternalTrafficPolicy of Kubernetes APIServer is set as enabled. If AntreaProxy is not enabled,
-    # this flag will not take effect.
+    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless the
+    # ServiceInternalTrafficPolicy feature gate of kube-apiserver is also enabled. If AntreaProxy is
+    # not enabled, this flag will not take effect.
     #  ServiceInternalTrafficPolicy: false
 
     # Enable traceflow which provides packet tracing feature to diagnose network issue.
@@ -4064,7 +4064,7 @@ metadata:
   annotations: {}
   labels:
     app: antrea
-  name: antrea-config-t6td8mhh77
+  name: antrea-config-td8b5dk788
   namespace: kube-system
 ---
 apiVersion: v1
@@ -4144,7 +4144,7 @@ spec:
             fieldRef:
               fieldPath: spec.serviceAccountName
         - name: ANTREA_CONFIG_MAP_NAME
-          value: antrea-config-t6td8mhh77
+          value: antrea-config-td8b5dk788
         image: projects.registry.vmware.com/antrea/antrea-ubuntu:latest
         imagePullPolicy: IfNotPresent
         livenessProbe:
@@ -4195,7 +4195,7 @@ spec:
         key: node-role.kubernetes.io/master
       volumes:
       - configMap:
-          name: antrea-config-t6td8mhh77
+          name: antrea-config-td8b5dk788
         name: antrea-config
       - name: antrea-controller-tls
         secret:
@@ -4511,7 +4511,7 @@ spec:
         operator: Exists
       volumes:
       - configMap:
-          name: antrea-config-t6td8mhh77
+          name: antrea-config-td8b5dk788
         name: antrea-config
       - hostPath:
           path: /etc/cni/net.d

diff --git a/build/yamls/antrea.yml b/build/yamls/antrea.yml
@@ -3773,9 +3773,9 @@ data:
     # this flag will not take effect.
     #  EndpointSlice: false
 
-    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless that feature gateway
-    # ServiceInternalTrafficPolicy of Kubernetes APIServer is set as enabled. If AntreaProxy is not enabled,
-    # this flag will not take effect.
+    # Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless the
+    # ServiceInternalTrafficPolicy feature gate of kube-apiserver is also enabled. If AntreaProxy is
+    # not enabled, this flag will not take effect.
     #  ServiceInternalTrafficPolicy: false
 
     # Enable traceflow which provides packet tracing feature to diagnose network issue.
@@ -4064,7 +4064,7 @@ metadata:
   annotations: {}
   labels:
     app: antrea
-  name: antrea-config-2tm2m9h7ck
+  name: antrea-config-cd9cm848fc
   namespace: kube-system
 ---
 apiVersion: v1
@@ -4135,7 +4135,7 @@ spec:
             fieldRef:
               fieldPath: spec.serviceAccountName
         - name: ANTREA_CONFIG_MAP_NAME
-          value: antrea-config-2tm2m9h7ck
+          value: antrea-config-cd9cm848fc
         image: projects.registry.vmware.com/antrea/antrea-ubuntu:latest
         imagePullPolicy: IfNotPresent
         livenessProbe:
@@ -4186,7 +4186,7 @@ spec:
         key: node-role.kubernetes.io/master
       volumes:
       - configMap:
-          name: antrea-config-2tm2m9h7ck
+          name: antrea-config-cd9cm848fc
         name: antrea-config
       - name: antrea-controller-tls
         secret:
@@ -4467,7 +4467,7 @@ spec:
         operator: Exists
       volumes:
       - configMap:
-          name: antrea-config-2tm2m9h7ck
+          name: antrea-config-cd9cm848fc
         name: antrea-config
       - hostPath:
           path: /etc/cni/net.d

diff --git a/build/yamls/base/conf/antrea-agent.conf b/build/yamls/base/conf/antrea-agent.conf
@@ -10,9 +10,9 @@ featureGates:
 # this flag will not take effect.
 #  EndpointSlice: false
 
-# Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless that feature gateway
-# ServiceInternalTrafficPolicy of Kubernetes APIServer is set as enabled. If AntreaProxy is not enabled,
-# this flag will not take effect.
+# Enables ServiceInternalTrafficPolicy in AntreaProxy. Don't enable this feature unless the
+# ServiceInternalTrafficPolicy feature gate of kube-apiserver is also enabled. If AntreaProxy is
+# not enabled, this flag will not take effect.
 #  ServiceInternalTrafficPolicy: false
 
 # Enable traceflow which provides packet tracing feature to diagnose network issue.

diff --git a/docs/feature-gates.md b/docs/feature-gates.md
@@ -88,7 +88,12 @@ kernel version must be >= 4.6 (as opposed to >= 4.4 without this feature).
 `ServiceInternalTrafficPolicy` enables internal traffic restrictions to only route internal
 traffic to Endpoints within the Node the traffic originated from. The "internal" traffic
 here refers to traffic originated from Pods in the current cluster. This can help to reduce
-costs and improve performance.
+costs and improve performance. Refer to this [link](https://kubernetes.io/docs/concepts/services-networking/service-traffic-policy/)
+for more information.
+
+#### Requirements for this Feature
+
+None
 
 ### AntreaPolicy