Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add powershell command replacement in windows doc #3264

Merged
merged 1 commit into from Jan 28, 2022

Conversation

GraysonWu
Copy link
Contributor

Fixes #3245 .

kube-proxy.yml uses the command pwsh which is not a valid command
when the Powershell version is earlier than 6.0.
This commit added this reminder and the command replacement in
windows doc.

Signed-off-by: wgrayson wgrayson@vmware.com

kube-proxy.yml uses the command `pwsh` which is not a valid command
when the Powershell version is earlier than 6.0.
This commit added this reminder and the command replacement in
windows doc.

Signed-off-by: wgrayson <wgrayson@vmware.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3264 (58e870c) into main (9809991) will decrease coverage by 18.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3264       +/-   ##
===========================================
- Coverage   59.66%   41.34%   -18.32%     
===========================================
  Files         331      199      -132     
  Lines       28437    24099     -4338     
===========================================
- Hits        16966     9964     -7002     
- Misses       9595    13104     +3509     
+ Partials     1876     1031      -845     
Flag Coverage Δ
kind-e2e-tests ?
unit-tests 41.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ovs/openflow/default.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/util/runtime/runtime.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 0.00% <0.00%> (-93.55%) ⬇️
pkg/ovs/openflow/logs.go 9.52% <0.00%> (-90.48%) ⬇️
pkg/apis/controlplane/register.go 0.00% <0.00%> (-90.00%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 0.00% <0.00%> (-87.91%) ⬇️
pkg/agent/client.go 0.00% <0.00%> (-77.42%) ⬇️
pkg/ovs/ovsconfig/ovs_client_linux.go 0.00% <0.00%> (-76.93%) ⬇️
pkg/flowaggregator/certificate.go 0.00% <0.00%> (-76.58%) ⬇️
...agent/controller/traceflow/traceflow_controller.go 0.00% <0.00%> (-69.86%) ⬇️
... and 246 more

Copy link
Contributor

@XinShuYang XinShuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/skip-all

@antoninbas antoninbas added the kind/documentation Categorizes issue or PR as related to a documentation. label Jan 28, 2022
@antoninbas antoninbas merged commit 7c3568e into antrea-io:main Jan 28, 2022
@antoninbas antoninbas deleted the update-windows-doc branch January 28, 2022 17:53
yanjunz97 pushed a commit to yanjunz97/antrea that referenced this pull request Feb 14, 2022
kube-proxy.yml uses the command `pwsh` which is not a valid command
when the Powershell version is earlier than 6.0.
This commit added this reminder and the command replacement in
windows doc.

Signed-off-by: wgrayson <wgrayson@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-proxy.yml in Antrea Windows doc doesn't work on some Windows OS
4 participants