[Windows] Enable EndpointSlices support on Antrea windows #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-windows-all |
Codecov Report
@@ Coverage Diff @@
## main #3321 +/- ##
==========================================
+ Coverage 60.95% 61.05% +0.09%
==========================================
Files 266 266
Lines 26508 26520 +12
==========================================
+ Hits 16159 16191 +32
+ Misses 8597 8542 -55
- Partials 1752 1787 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/test-windows-networkpolicy |
XinShuYang
force-pushed
the
epsl
branch
3 times, most recently
from
2b349ef
to
147b747
Compare
XinShuYang
changed the title
|
/test-windows-proxyall-e2e |
XinShuYang
changed the title
XinShuYang
changed the title
|
/test-windows-proxyall-e2e |
wenyingd
reviewed
Feb 22, 2022
third_party/proxy/config/config.go
Outdated
| @@ -347,7 +347,8 @@ func (c *EndpointSliceConfig) handleUpdateEndpointSlice(oldObj, newObj interface | |||
| return | |||
| } | |||
| for _, h := range c.eventHandlers { | |||
| klog.V(4).Infof("Calling handler.OnEndpointSliceUpdate") | |||
| klog.V(4).Infof("Calling handler.OnEndpointSliceUpdate from %+v", oldEndpointSlice) | |||
There was a problem hiding this comment.
Use klog.V(4).InfoS()?
One log including both old and new Endpointslice is enought.
third_party/proxy/config/config.go
Outdated
| @@ -366,7 +367,7 @@ func (c *EndpointSliceConfig) handleDeleteEndpointSlice(obj interface{}) { | |||
| } | |||
| } | |||
| for _, h := range c.eventHandlers { | |||
| klog.V(4).Infof("Calling handler.OnEndpointsDelete") | |||
| klog.V(4).Infof("Calling handler.OnEndpointsDelete %+v", endpointSlice) | |||
There was a problem hiding this comment.
Updated, thanks!
|
/test-windows-all |
|
@wenyingd Hi Wenying，do you have more comments on this PR? |
tnqn
requested changes
Feb 25, 2022
third_party/proxy/config/config.go
Outdated
| @@ -330,7 +330,7 @@ func (c *EndpointSliceConfig) handleAddEndpointSlice(obj interface{}) { | |||
| return | |||
| } | |||
| for _, h := range c.eventHandlers { | |||
| klog.V(4).Infof("Calling handler.OnEndpointSliceAdd %+v", endpointSlice) | |||
| klog.V(4).InfoS("Calling handler.OnEndpointSliceAdd", endpointSlice) | |||
There was a problem hiding this comment.
structured logging must have pairs of key and value, otherwise the log wouldn't be formated properly.
InfoS("log body", "key1", value1, "key2", values)
It should be klog.V(4).InfoS("Calling handler.OnEndpointSliceAdd", "endpointSlice", endpointSlice)
There was a problem hiding this comment.
Updated, thanks @tnqn.
* Enable endpointslices feature in antrea-windows.yml * Make some endpointslices logs more accurate Signed-off-by: Shuyang Xin <gavinx@vmware.com>
|
/test-windows-all |
tnqn
added
the
action/release-note
bangqipropel
pushed a commit
to bangqipropel/antrea
that referenced
this pull request
Mar 2, 2022
…3321) * Enable endpointslices feature in antrea-windows.yml * Make some endpointslices logs more accurate Signed-off-by: Shuyang Xin <gavinx@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuyang Xin gavinx@vmware.com