Add [antctl mc] command for antrea multicluster resources #3341

hjiajing · 2022-02-22T11:40:51Z

antctl: add multicluster subcommand

Add a new subcommand for antrea multicluster and add get verb for query resources. We could list or get mc resource by antctl mc get .

Example:

# ./antctl mc get ri -A
NAMESPACE                NAME                                                       KIND
antrea-mcs-ns            antrea-multicluster-test-east-nginx-endpoints              ResourceImport
antrea-mcs-ns            antrea-multicluster-test-east-nginx-service                ResourceImport
antrea-mcs-ns            antrea-multicluster-test-west-nginx-endpoints              ResourceImport
antrea-mcs-ns            antrea-multicluster-test-west-nginx-service                ResourceImport

In the future, other verb like create or delete also could be added to the sub-command mc if it is nesscessary.

hjiajing · 2022-02-22T11:41:13Z

@luolanzone Could you please help to review. Thanks

hjiajing · 2022-02-22T11:41:26Z

@bangqipropel Could you please help to review. Thanks

lgtm-com · 2022-02-22T12:11:28Z

This pull request introduces 1 alert when merging cc281ca into 3f30d84 - view on LGTM.com

new alerts:

1 for Useless assignment to local variable

codecov-commenter · 2022-02-22T13:00:26Z

Codecov Report

Merging #3341 (ab76b64) into main (24f85ce) will decrease coverage by 7.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3341      +/-   ##
==========================================
- Coverage   62.11%   55.05%   -7.07%     
==========================================
  Files         269      375     +106     
  Lines       26852    41332   +14480     
==========================================
+ Hits        16680    22756    +6076     
- Misses       8334    16179    +7845     
- Partials     1838     2397     +559

Flag	Coverage Δ
integration-tests	`35.76% <ø> (?)`
kind-e2e-tests	`55.80% <ø> (+6.85%)`	⬆️
unit-tests	`42.55% <50.00%> (+0.21%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/antctl/antctl.go	`66.66% <ø> (ø)`
pkg/antctl/command_definition.go	`44.18% <33.33%> (-7.79%)`	⬇️
pkg/antctl/command_list.go	`48.48% <100.00%> (+0.79%)`	⬆️
pkg/agent/util/ethtool/ethtool_linux.go	`0.00% <0.00%> (-70.00%)`	⬇️
pkg/agent/openflow/meters_linux.go	`36.36% <0.00%> (-18.19%)`	⬇️
pkg/agent/flowexporter/exporter/certificate.go	`33.33% <0.00%> (-16.67%)`	⬇️
pkg/apis/controlplane/v1beta2/sets.go	`51.21% <0.00%> (-9.76%)`	⬇️
pkg/agent/flowexporter/exporter/exporter.go	`74.51% <0.00%> (-6.78%)`	⬇️
...kg/agent/flowexporter/connections/conntrack_ovs.go	`72.72% <0.00%> (-4.85%)`	⬇️
.../registry/networkpolicy/clustergroupmember/rest.go	`84.31% <0.00%> (-3.93%)`	⬇️
... and 176 more

luolanzone · 2022-02-22T14:09:09Z

pkg/antctl/command_definition.go

+		Short: "Sub-commands of multiple cluster",
+		Long:  "Sub-commands of multiple cluster",


maybe 'Sub-commands of Multi-cluster feature'?

luolanzone · 2022-02-22T14:17:05Z

pkg/antctl/raw/multicluster/command.go

+func init() {
+	GetCmd = &cobra.Command{
+		Use:   "get",
+		Short: "List or query resources of multiple cluster",


s/List or query resources of multiple cluster/Display one or many resources in a ClusterSet/

luolanzone · 2022-02-22T14:18:56Z

pkg/antctl/raw/multicluster/resourceimport.go

+			"resourceimports",
+			"ri",
+		},
+		Short:   "Print Multi-Cluster resource imports",


s/resource imports/ResourceImports/

pkg/antctl/raw/multicluster/resourceimport.go

luolanzone · 2022-02-22T14:24:22Z

pkg/antctl/raw/multicluster/resourceimport.go

+	}
+	o := &resourceImportOptions{}
+	options = o
+	command.Flags().StringVarP(&o.namespace, "namespace", "n", "", "namespace of resource import")


s/namespace of resource import/Namespace of ResourceImports/

luolanzone · 2022-02-22T14:26:07Z

pkg/antctl/raw/multicluster/resourceimport.go

+	options = o
+	command.Flags().StringVarP(&o.namespace, "namespace", "n", "", "namespace of resource import")
+	command.Flags().StringVarP(&o.outputFormat, "output", "o", "", "Output format. Supported formats: json|yaml")
+	command.Flags().BoolVarP(&o.allNamespace, "all-namespace", "A", false, "Get resource of all namespace or not")


better to refer kubectl get help info and change it as below:

If present, list ResourceImports across all namespaces.

luolanzone · 2022-02-22T14:27:50Z

pkg/antctl/raw/multicluster/resourceimport.go

+
+func output(resourceImports []multiclusterv1alpha1.ResourceImport) string {
+	var output strings.Builder
+	formatter := "%-25s%-50s%-25s\n"


can the name column's length be wider? I got below results:

NAMESPACE NAME KIND docs default-nginx-endpoints ResourceImport docs default-nginx-service ResourceImport docs test-cluster-temp-kube-system-lan-k8s-temp-0-tunnelendpointResourceImport docs test-cluster-west-kube-system-lan-k8s-0-0-tunnelendpointResourceImport

luolanzone · 2022-02-22T14:28:55Z

pkg/antctl/raw/multicluster/resourceimport.go

+			fmt.Println("No resource found")
+			return nil
+		}
+		return fmt.Errorf("Error from server (NotFound): resourceimport %s not found.", args[0])


s/resourceimport/ResourceImport/

luolanzone · 2022-02-22T14:32:12Z

pkg/antctl/raw/multicluster/resourceimport.go

+	}
+	if len(res) == 0 {
+		if len(args) == 0 {
+			fmt.Println("No resource found")


better to return a message like below to allow user to understand it's empty result in a given Namespace.

No resources found in kube-system namespace.

luolanzone · 2022-02-22T14:33:09Z

pkg/antctl/raw/multicluster/resourceimport.go

+	resourceImportList := &multiclusterv1alpha1.ResourceImportList{}
+	err = k8sClient.List(context.TODO(), resourceImportList, &client.ListOptions{Namespace: options.namespace})
+
+	for _, ri := range resourceImportList.Items {


assign len(args) to a var if you will use it multiple times.

luolanzone · 2022-02-23T09:43:44Z

pkg/antctl/raw/multicluster/resourceimport.go

+var resourceImportExample = strings.Trim(`
+Gel all resource imports of cluster set in default namesapce
+$ antctl get resourceimport
+Get all resource imports of cluster set in all namespace


s/all namespace/all namespaces/

luolanzone · 2022-02-23T09:50:03Z

pkg/antctl/raw/multicluster/resourceimport.go

+var options *resourceImportOptions
+
+var resourceImportExample = strings.Trim(`
+Gel all resource imports of cluster set in default namesapce


s/of cluster set/ of a cluster set/

luolanzone · 2022-02-23T09:51:20Z

pkg/antctl/raw/multicluster/resourceimport.go

+$ antctl get resourceimport -o json
+`, "\n")
+
+func (o *resourceImportOptions) validateAndComplete() error {


The returned err is always nil, you can remove the return parameter error.

luolanzone · 2022-02-23T09:54:32Z

pkg/antctl/raw/multicluster/resourceimport.go

+	if o.allNamespace {
+		o.namespace = metav1.NamespaceAll
+	} else if o.namespace == "" {
+		o.namespace = metav1.NamespaceDefault
+	}


this can be:

if o.allNamespace { o.namespace = metav1.NamespaceAll return } if o.namespace == "" { o.namespace = metav1.NamespaceDefault return }

luolanzone · 2022-02-23T09:57:21Z

pkg/antctl/raw/multicluster/resourceimport.go

+			}
+			return nil
+		}
+		return fmt.Errorf("Error from server (NotFound): ResourceImport %s not found.", args[0])


s/Error/error/
and remove the punctuation.

why is it (NotFound) error when res size is zero? I suppose only when args[0] is not empty, you can tell it's NotFound. you should also handle the case when other args are not empty but args[0] is empty.

luolanzone · 2022-02-23T10:03:33Z

pkg/antctl/raw/multicluster/resourceimport.go

+	})
+
+	for _, ri := range resourceImports {
+		fmt.Fprintf(&output, formatter, ri.Namespace, ri.Name, ri.Kind)


the kind here shouldn't be ri.Kind, it's always ResourceImport, it should be re.Spec.Kind

luolanzone · 2022-02-23T10:08:24Z

pkg/antctl/raw/multicluster/resourceimport.go

+	options = o
+	command.Flags().StringVarP(&o.namespace, "namespace", "n", "", "Namespace of ResourceImports")
+	command.Flags().StringVarP(&o.outputFormat, "output", "o", "", "Output format. Supported formats: json|yaml")
+	command.Flags().BoolVarP(&o.allNamespace, "all-namespace", "A", false, "If present, list ResourceImports across all namespaces")


s/all-namespace/all-namespaces/

luolanzone · 2022-02-23T10:11:02Z

@jianjuns @antoninbas Could you help to review this PR? we plan to have a mc sub command and move all related commands into this command.

antoninbas

In the PR description, replace:

In the future, other verb like create or delete also could be added to the sub-command mc if it is nesscessary.

with

In the future, other verbs like create or delete also could be added to the mc sub-command if it is necessary.

BTW, we usually try to include more information (same as in the PR description) in the commit message (right now yours is empty), so that this information stays available in the git history after we merge the PR. See https://cbea.ms/git-commit/

antoninbas · 2022-02-23T19:11:17Z

pkg/antctl/raw/multicluster/resourceimport.go

+Gel all resource imports of cluster set in default namesapce
+$ antctl get resourceimport
+Get all resource imports of cluster set in all namespace
+$ antctl get resoruceimport -A


typo: s/resoruceimport/resourceimport

antoninbas · 2022-02-23T19:11:43Z

pkg/antctl/raw/multicluster/resourceimport.go

+
+var resourceImportExample = strings.Trim(`
+Gel all resource imports of cluster set in default namesapce
+$ antctl get resourceimport


Aren't those sample commands missing the mc group?

e.g. antctl mc get resourceimport

antoninbas · 2022-02-23T19:12:44Z

pkg/antctl/command_list.go

@@ -63,7 +63,7 @@ func (cl *commandList) applyToRootCommand(root *cobra.Command, client AntctlClie

 	for _, cmd := range cl.rawCommands {
 		if (runtime.Mode == runtime.ModeAgent && cmd.supportAgent) ||
-			(runtime.Mode == runtime.ModeController && cmd.supportController) {
+			(runtime.Mode == runtime.ModeController && cmd.supportController) || cmd.commandGroup == mc {


I am trying to understand this. So the mc commands are always added, even when I run antctl from inside an antrea-agent Pod. Is this right?

looks like it will be added no matter it's inside a Pod or not, @hjiajing I think you need to check both cmd.supportController and cmd.supportAgent so it won't add mc sub-command when it's running in a Pod.

antoninbas · 2022-02-23T19:16:14Z

pkg/antctl/raw/multicluster/resourceimport.go

+			"ri",
+		},
+		Short:   "Print Multi-Cluster ResourceImports",
+		Args:    cobra.MaximumNArgs(1),


I don't see any reference to this positional argument in help messages

antoninbas · 2022-02-23T19:16:55Z

pkg/antctl/raw/multicluster/resourceimport.go

+		if argsNum > 0 && ri.Name == args[0] {
+			res = append(res, ri)
+			break


shouldn't you use a k8sClient.Get instead of a k8sClient.List for this case (single resource needs to be retrieved by name)?

antoninbas · 2022-02-23T19:17:07Z

pkg/antctl/raw/multicluster/resourceimport.go

+	if len(res) == 0 {
+		if argsNum == 0 {
+			if options.namespace != "" {
+				fmt.Printf("No resource found in namespace %s\n", options.namespace)


s/namespace/Namespace everywhere

luolanzone · 2022-02-28T08:34:40Z

pkg/antctl/raw/multicluster/resourceimport.go

+		if err != nil {
+			return err
+		}
+		fmt.Println(string(yamlOutput))


Could you check the yaml output? I got a quite strange output like below, something like raw byte data.

managedfields: - manager: antrea-mc-controller operation: Update apiversion: multicluster.crd.antrea.io/v1alpha1 time: "2022-01-11T16:53:56+08:00" fieldstype: FieldsV1 fieldsv1: raw: - 123 - 34 - 102 - 58 - 115 - 112 - 101 - 99 - 34 - 58 - 123 - ...

btw, why am I getting empty string in kind and apiversion? and the yaml format should be similar as 'kubectl get pod podname -o yaml', Could you check it? thanks.

./bin/antctl-darwin mc get resourceimports default-nginx-endpoints -n docs -o yaml - typemeta: kind: "" apiversion: ""

@hjiajing Could you also check if possible to remove the last empty line when we execute antctl command? I think we should remote this unnecessary empty line. maybe fix it in a separate PR since it's not a specific issue for mc, thanks.

It is caused by yaml module, and I changed it to sigs.k8s.io/yaml then it works fine. About the empty line, I will fix it later in a separate PR

@hjiajing I tried -o yaml but below info are missing, Could you double check? the json output has the same problem.

apiVersion: multicluster.crd.antrea.io/v1alpha1 kind: ResourceImport

@luolanzone Got it. I found that when I tried to get or list all resources, not only CRDs but also k8s resources like Pod. The Typemeta field is empty. It's confused, I'm trying to solve it now.

luolanzone · 2022-02-28T08:36:18Z

pkg/antctl/raw/multicluster/resourceimport.go

+			return err
+		}
+
+		fmt.Println(prettyJson.String())


you shouldn't print json in an array when user gives one specific ResourceImport.

luolanzone · 2022-02-28T08:37:49Z

pkg/antctl/raw/multicluster/resourceimport.go

+	options = o
+	command.Flags().StringVarP(&o.namespace, "namespace", "n", "", "Namespace of ResourceImports")
+	command.Flags().StringVarP(&o.outputFormat, "output", "o", "", "Output format. Supported formats: json|yaml")
+	command.Flags().BoolVarP(&o.allNamespace, "all-namespaces", "A", false, "If present, list ResourceImports across all Namespaces")


better to rename allNamespace to allNamespaces

bangqipropel · 2022-02-28T08:58:13Z

@luolanzone #3341 (comment) we don't want the raw data? maybe I have the same output

luolanzone · 2022-02-28T09:02:23Z

@luolanzone #3341 (comment) we don't want the raw data? maybe I have the same output

Please compare json and yaml output, they are obviously different beside format. that's not correct.

luolanzone · 2022-03-01T13:46:27Z

pkg/antctl/raw/multicluster/resourceimport.go

+	var outputType string
+	if argsNum > 0 {
+		outputType = singleType
+	} else {
+		outputType = multipleType
+	}


maybe just a bool variable? I feel it's redundant to use two variables. it's can be a bool with a name like isSingleType

luolanzone · 2022-03-03T14:08:10Z

@hjiajing it looks good to me overall, but there is a tidy check failure, please fix it: https://github.com/antrea-io/antrea/runs/5402785503?check_suite_focus=true
@antoninbas @jianjuns Could you help to take a look? thanks.

antoninbas · 2022-03-03T18:14:51Z

pkg/antctl/raw/multicluster/resourceimport.go

+$ antctl mc get resourceimport -A
+Get all resource imports of specified namespace
+$ antctl mc get resourceimport -n <NAMESPACE>
+Get all resource imports and print json format


Suggested change

Get all resource imports and print json format

Get all resource imports and print then in JSON format

done. BTW, maybe it is "them" not "then" ?

antoninbas · 2022-03-03T18:15:13Z

pkg/antctl/raw/multicluster/resourceimport.go

+$ antctl mc get resourceimport
+Get all resource imports of a cluster set in all Namespaces
+$ antctl mc get resourceimport -A
+Get all resource imports of specified namespace


Suggested change

Get all resource imports of specified namespace

Get all resource imports of in the specified Namespace

antoninbas · 2022-03-03T18:15:28Z

pkg/antctl/raw/multicluster/resourceimport.go

+$ antctl mc get resourceimport -n <NAMESPACE>
+Get all resource imports and print json format
+$ antctl mc get resourceimport -o json
+Get a specified resourceimport


Suggested change

Get a specified resourceimport

Get the specified resourceimport

antoninbas · 2022-03-03T18:18:21Z

pkg/antctl/raw/multicluster/resourceimport.go

+		return err
+	}
+
+	isSingleType := false


why is this called isSingleType?

I would suggest something like singleResource or retrieveByName

antoninbas · 2022-03-03T18:19:19Z

pkg/antctl/raw/multicluster/resourceimport.go

+	switch isSingleType {
+	case true:


why use switch / case for a single boolean value, instead of if / else?

maybe write helper functions for the 2 cases for code readability if possible

jianjuns · 2022-03-03T18:54:35Z

pkg/antctl/raw/multicluster/resourceimport.go

+
+var options *resourceImportOptions
+
+var resourceImportExample = strings.Trim(`


Nit: resourceImportExample -> resourceImportExamples

jianjuns · 2022-03-03T18:59:40Z

pkg/antctl/raw/multicluster/resourceimport.go

+		res = resourceImportList.Items
+	}
+
+	switch options.outputFormat {


These codes can be common for all commands? And do we have a way to share output code in antctl/command_definition.go?

Hello Jianjun. Thanks for comment. I tried to share output code in comman_definition.go, but I found that the output method is used by commandDefinition rather than raw command, so maybe it is not easy to share the output code. And the command antctl mc get resources will list and get different resources, so maybe it's difficult to be common for all list&get commands. I don't know if you have some detailed suggestions, thank you .

At least line 174 - 185 can be shared? For line 187 - 195, could we define an interface similar to (or even share) TableOutput in antctl/transform/common?

okay, thanks. I'll do it.

luolanzone

LGTM

luolanzone · 2022-03-07T01:32:26Z

@hjiajing there are some new comments from Jianjun and antonin, please address it. thanks.

jianjuns · 2022-03-10T01:41:43Z

we have clusterSet structure, the table outputs are different if we enter a clusterSetID or not
Could you point to me the code of the above? I guess that is what I missed.

bangqipropel · 2022-03-10T01:49:58Z

@jianjuns Sorry my reply to comment have some problem, just reply it here.
Here is my codes for ClusterSet output, similar to Jiajing's code.

https://github.com/antrea-io/antrea/pull/3287/files#:~:text=Println(string(yamlByte))-,default%3A,%7D,-51%20%20pkg/antctl

the whole PR is : #3287

jianjuns · 2022-03-10T02:26:11Z

@bangqipropel: I checked. But if outputAllClusterSet is the only case, we can just handle it specially. The question is do we believe the TableOutput interface works for most commands.

It is not an issue tableOutputForGetCommands() is in commandDefinition, we can always move the func out to be shared. I checked its code seems does not depends on any commandDefinition state.

bangqipropel · 2022-03-10T23:10:37Z

pkg/antctl/raw/multicluster/resourceimport.go

+var options *resourceImportOptions
+
+var resourceImportExamples = strings.Trim(`
+Gel all resource imports of a cluster set in default Namespace


maybe we also need address this comment here? #3287 (comment)

jianjuns

LGTM.

Several nits.

jianjuns · 2022-03-11T18:43:11Z

pkg/antctl/command_definition.go

@@ -387,7 +393,7 @@ func jsonEncode(obj interface{}, output *bytes.Buffer) error {
 	return nil
 }

-func (cd *commandDefinition) jsonOutput(obj interface{}, writer io.Writer) error {
+func JsonOutput(obj interface{}, writer io.Writer) error {


Maybe move these funcs to a separate file like output.go. If it is easier for import, even a separate pkg.

okay. I moved all the output functions to the output.go. Now that the command_definition.go only contains the commandDefinition(cd) methods

jianjuns · 2022-03-11T18:45:29Z

pkg/antctl/raw/multicluster/get/resourceimport.go

+var options *resourceImportOptions
+
+var resourceImportExamples = strings.Trim(`
+Gel all resource imports of a cluster set in default Namespace


Again, we capitalize the first letter of resource types, so: ResourceImports, ClusterSet

jianjuns

LGTM

tnqn · 2022-03-16T04:05:19Z

Just found #3287 is based on this PR.
I have left some comments there, could you check #3287 (comment) and #3287 (review)? @hjiajing

hjiajing · 2022-03-16T04:25:42Z

@tnqn hello Quan. Thanks for comment. I have got the comment this morning so I made some changes. Just move the output.go to a new package in order to avoid cycle import. About other comments, I'm addressing them now. Thanks.

hjiajing · 2022-03-18T09:56:37Z

@tnqn Hello Quan, Could you please help to review, thanks

tnqn

Two nits, otherwise LGTM

tnqn · 2022-03-18T10:10:48Z

pkg/antctl/raw/multicluster/get/resourceimport.go

+
+		if len(resourceImportList.Items) == 0 {
+			if options.namespace != "" {
+				fmt.Printf("No resource found in Namespace %s\n", options.namespace)


Same as #3287 (comment)
I think this information normally goes to stderr to make user able to distinguish it from valid output easily.

fmt.Fprintln(cmd.ErrOrStderr(), "No resources found")

pkg/antctl/raw/multicluster/scheme/scheme.go

tnqn · 2022-03-18T10:24:53Z

@hjiajing could you add more details to the commit message, for example:

antctl: add multicluster subcommand

Add a new subcommand for antrea multicluster and add get verb for query
resources. We could list or get mc resource by antctl mc get <Resource>.

Example:

# ./antctl mc get ri -A
NAMESPACE                NAME                                                                                  KIND
antrea-mcs-ns            antrea-multicluster-test-east-nginx-endpoints              ResourceImport
antrea-mcs-ns            antrea-multicluster-test-east-nginx-service                  ResourceImport
antrea-mcs-ns            antrea-multicluster-test-west-nginx-endpoints             ResourceImport
antrea-mcs-ns            antrea-multicluster-test-west-nginx-service                 ResourceImport

In the future, other verb like create or delete also could be added to
the sub-command mc if it is nesscessary.

BTW, why the output in the example is not aligned? Is it caused by copy-paste or the real output is not aligned?

hjiajing · 2022-03-18T14:58:22Z

@tnqn I updated the commit message, but I found that the output is not aligned again. But I pasted the output to the editor, it's aligned. Maybe it cause by the copy-paste. But, it's odd that when I paste again, it's aligned.

tnqn · 2022-03-18T15:10:44Z

@hjiajing you didn't update commit message, it's still empty. I see Antonin suggested the same here: #3341 (review)
Note that commit message is different from PR description.

antctl: add multicluster subcommand  <---- this is the commit message title I suggested

Add a new subcommand for antrea multicluster and add get verb for query       <---- this is the commit message body
resources. We could list or get mc resource by antctl mc get <Resource>.

Example:

# ./antctl mc get ri -A
NAMESPACE                NAME                                                                                  KIND
antrea-mcs-ns            antrea-multicluster-test-east-nginx-endpoints              ResourceImport
antrea-mcs-ns            antrea-multicluster-test-east-nginx-service                  ResourceImport
antrea-mcs-ns            antrea-multicluster-test-west-nginx-endpoints             ResourceImport
antrea-mcs-ns            antrea-multicluster-test-west-nginx-service                 ResourceImport

In the future, other verb like create or delete also could be added to
the sub-command mc if it is nesscessary.

tnqn · 2022-03-18T16:21:12Z

/test-multicluster-e2e
/test-e2e
/skip-conformance
/skip-networkpolicy

tnqn · 2022-03-18T16:42:01Z

code is not gofmted:

===> Running golangci (linux) <===
pkg/antctl/command_definition_test.go:33: File is not `gofmt`-ed with `-s` (gofmt)
	"antrea.io/antrea/pkg/agent/apiserver/handlers/podinterface"

Add a new subcommand for antrea multicluster and add get verb for query resources. We could list or get mc resource by antctl mc get <Resource>. Example: NAMESPACE NAME KIND antrea-mcs-ns antrea-multicluster-test-east-nginx-endpoints ResourceImport antrea-mcs-ns antrea-multicluster-test-east-nginx-service ResourceImport antrea-mcs-ns antrea-multicluster-test-west-nginx-endpoints ResourceImport antrea-mcs-ns antrea-multicluster-test-west-nginx-service ResourceImport In the future, other verb like create or delete also could be added to the sub-command mc if it is nesscessary. Signed-off-by: hjiajing <hjiajing@vmware.com>

hjiajing · 2022-03-21T03:11:00Z

@tnqn done. Thanks for your comments.

hjiajing · 2022-03-21T03:11:09Z

/test-multicluster-e2e
/test-e2e
/skip-conformance
/skip-networkpolicy

tnqn

LGTM

tnqn · 2022-03-21T05:32:56Z

/test-integration

tnqn · 2022-03-21T05:33:12Z

/skip-conformance
/skip-networkpolicy

luolanzone reviewed Feb 22, 2022

View reviewed changes

hjiajing force-pushed the mc branch 2 times, most recently from 6a22134 to c593474 Compare February 23, 2022 08:06

luolanzone reviewed Feb 23, 2022

View reviewed changes

luolanzone requested a review from jianjuns February 23, 2022 10:10

luolanzone requested a review from antoninbas February 23, 2022 10:11

antoninbas reviewed Feb 23, 2022

View reviewed changes

luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Feb 24, 2022

luolanzone mentioned this pull request Feb 24, 2022

Add antctl resourceImport command #3327

Closed

hjiajing force-pushed the mc branch from c593474 to f1832da Compare February 28, 2022 07:06

luolanzone reviewed Feb 28, 2022

View reviewed changes

luolanzone mentioned this pull request Feb 28, 2022

Antctl for multicluster #3287

Merged

hjiajing force-pushed the mc branch from f1832da to bb1b385 Compare March 1, 2022 06:12

luolanzone reviewed Mar 1, 2022

View reviewed changes

hjiajing force-pushed the mc branch 4 times, most recently from 49e3d4d to aa5a964 Compare March 3, 2022 05:59

antoninbas reviewed Mar 3, 2022

View reviewed changes

jianjuns reviewed Mar 3, 2022

View reviewed changes

luolanzone previously approved these changes Mar 7, 2022

View reviewed changes

bangqipropel reviewed Mar 10, 2022

View reviewed changes

hjiajing force-pushed the mc branch from c16e529 to 1560dbf Compare March 11, 2022 10:12

jianjuns reviewed Mar 11, 2022

View reviewed changes

hjiajing force-pushed the mc branch from 1560dbf to 710ff68 Compare March 15, 2022 12:02

jianjuns previously approved these changes Mar 15, 2022

View reviewed changes

hjiajing dismissed jianjuns’s stale review via cbca3ff March 16, 2022 04:17

hjiajing force-pushed the mc branch from 710ff68 to cbca3ff Compare March 16, 2022 04:17

hjiajing force-pushed the mc branch from cbca3ff to 03ad9ec Compare March 18, 2022 09:55

tnqn reviewed Mar 18, 2022

View reviewed changes

hjiajing force-pushed the mc branch from 03ad9ec to 69fa1a4 Compare March 18, 2022 14:50

hjiajing force-pushed the mc branch from 69fa1a4 to ab76b64 Compare March 21, 2022 03:09

tnqn approved these changes Mar 21, 2022

View reviewed changes

tnqn merged commit 9879f4c into antrea-io:main Mar 21, 2022

tnqn added the action/release-note Indicates a PR that should be included in release notes. label Mar 21, 2022

		Short: "Sub-commands of multiple cluster",
		Long: "Sub-commands of multiple cluster",

	Get all resource imports and print json format
	Get all resource imports and print then in JSON format

	Get all resource imports of specified namespace
	Get all resource imports of in the specified Namespace

	Get a specified resourceimport
	Get the specified resourceimport


		var options *resourceImportOptions

		var resourceImportExample = strings.Trim(`

Add [antctl mc] command for antrea multicluster resources #3341

Add [antctl mc] command for antrea multicluster resources #3341

Conversation

hjiajing commented Feb 22, 2022 • edited

hjiajing commented Feb 22, 2022

hjiajing commented Feb 22, 2022

lgtm-com bot commented Feb 22, 2022

codecov-commenter commented Feb 22, 2022 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luolanzone Feb 23, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luolanzone commented Feb 23, 2022

antoninbas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luolanzone Feb 28, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bangqipropel commented Feb 28, 2022

luolanzone commented Feb 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luolanzone commented Mar 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hjiajing commented Feb 22, 2022 •

edited

codecov-commenter commented Feb 22, 2022 •

edited

luolanzone Feb 23, 2022 •

edited

luolanzone Feb 28, 2022 •

edited