Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale ClusterIP routes after Antrea restart #3465

Merged
merged 1 commit into from Mar 30, 2022

Conversation

hongliangl
Copy link
Contributor

Fix #3131

Signed-off-by: Hongliang Liu lhongliang@vmware.com

@hongliangl hongliangl changed the title Remove stale clusterIP route after Antrea reboot Remove stale ClusterIP route after Antrea reboot Mar 17, 2022
@hongliangl hongliangl changed the title Remove stale ClusterIP route after Antrea reboot Remove stale ClusterIP route after Antrea restart Mar 17, 2022
pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved
pkg/agent/route/route_linux.go Show resolved Hide resolved
test/e2e/basic_test.go Outdated Show resolved Hide resolved
test/e2e/basic_test.go Outdated Show resolved Hide resolved
test/e2e/basic_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #3465 (9db9985) into main (5a214e5) will decrease coverage by 10.10%.
The diff coverage is 37.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3465       +/-   ##
===========================================
- Coverage   65.56%   55.46%   -10.11%     
===========================================
  Files         278      392      +114     
  Lines       27750    53632    +25882     
===========================================
+ Hits        18195    29746    +11551     
- Misses       7628    21415    +13787     
- Partials     1927     2471      +544     
Flag Coverage Δ
e2e-tests 53.23% <0.00%> (?)
integration-tests 38.21% <ø> (?)
kind-e2e-tests 55.24% <62.50%> (-0.05%) ⬇️
unit-tests 43.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/agent/route/route_linux.go 42.42% <37.73%> (-7.02%) ⬇️
pkg/controller/ipam/antrea_ipam_controller.go 26.26% <0.00%> (-54.02%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 26.31% <0.00%> (-40.36%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 61.46% <0.00%> (-29.97%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 51.90% <0.00%> (-28.10%) ⬇️
pkg/controller/egress/controller.go 62.19% <0.00%> (-26.26%) ⬇️
pkg/controller/ipam/validate.go 57.95% <0.00%> (-24.31%) ⬇️
pkg/controller/egress/store/egressgroup.go 36.20% <0.00%> (-23.52%) ⬇️
pkg/agent/util/iptables/lock.go 60.00% <0.00%> (-21.82%) ⬇️
pkg/controller/externalippool/validate.go 55.17% <0.00%> (-21.02%) ⬇️
... and 353 more

pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved
pkg/agent/route/route_linux.go Outdated Show resolved Hide resolved
test/e2e/basic_test.go Outdated Show resolved Hide resolved
test/e2e/basic_test.go Outdated Show resolved Hide resolved
@hongliangl hongliangl force-pushed the remove-stale-clusterip-route branch 2 times, most recently from 2f3900d to 4770f90 Compare March 19, 2022 03:21
@hongliangl hongliangl changed the title Remove stale ClusterIP route after Antrea restart Remove stale ClusterIP routes after Antrea restart Mar 19, 2022
@hongliangl
Copy link
Contributor Author

/test-all-features-conformance
/test-conformance
/test-e2e
/test-flexible-ipam-e2e
/test-multicluster-e2e
/test-networkpolicy
/test-windows-conformance
/test-windows-e2e
/test-windows-networkpolicy
/test-windows-proxyall-e2e
/test-integration

antoninbas
antoninbas previously approved these changes Mar 21, 2022
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

/test-ipv6-e2e
/test-ipv6-only-e2e

1 similar comment
@hongliangl
Copy link
Contributor Author

/test-ipv6-e2e
/test-ipv6-only-e2e

Fix antrea-io#3131

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl
Copy link
Contributor Author

/test-all-features-conformance
/test-conformance
/test-e2e
/test-flexible-ipam-e2e
/test-ipv6-conformance
/test-ipv6-e2e
/test-ipv6-networkpolicy
/test-ipv6-only-conformance
/test-ipv6-only-e2e
/test-ipv6-only-networkpolicy
/test-multicluster-e2e
/test-networkpolicy
/test-windows-conformance
/test-windows-e2e
/test-windows-networkpolicy
/test-windows-proxyall-e2e
/test-integration

@hongliangl
Copy link
Contributor Author

/test-ipv6-e2e
/test-ipv6-only-conformance
/test-windows-conformance

Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit 8f9c4df into antrea-io:main Mar 30, 2022
@antoninbas
Copy link
Contributor

@hongliangl do you want to backport this to v1.6?

GraysonWu pushed a commit to GraysonWu/antrea that referenced this pull request Mar 30, 2022
Fixes antrea-io#3131

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl
Copy link
Contributor Author

hongliangl commented Mar 31, 2022

@antoninbas Done by #3565.

BTW, I got an error like the following when running hack/cherry-pick-pull.sh, so I made the PR manually.

Creating pull request for lhongliang:automated-cherry-pick-of-#3465-upstream-release-1.6 into release-1.6 in antrea-io/antrea

pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, Head repository can't be blank, No commits between antrea-io:release-1.6 and lhongliang:automated-cherry-pick-of-#3465-upstream-release-1.6, Head ref must be a branch, not all refs are readable (createPullRequest)

@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label Mar 31, 2022
@hongliangl hongliangl deleted the remove-stale-clusterip-route branch April 28, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Antrea ProxyAll doesn't remove stale routes on the host
4 participants