Remove custom spark home and custom binarires for spark #27646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
pierrejeambrun,
eladkal,
dstandish and
jedcunningham
pierrejeambrun
approved these changes
Nov 13, 2022
ottomata
added a commit
to ottomata/airflow
that referenced
this pull request
Mar 13, 2023
The list of allowed values for spark-binary was restricted in apache#27646. Add spark3-submit to this list to allow for distributions of Spark 3 that install the binary this way. See also apache#30065.
potiuk
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Add spark3-submit to list of allowed spark-binary values The list of allowed values for spark-binary was restricted in #27646. Add spark3-submit to this list to allow for distributions of Spark 3 that install the binary this way. See also #30065. * Fix lint errors in spark.rst and test_spark_submit.py
a0x8o
added a commit
to a0x8o/airflow
that referenced
this pull request
Mar 15, 2023
* Add spark3-submit to list of allowed spark-binary values The list of allowed values for spark-binary was restricted in apache/airflow#27646. Add spark3-submit to this list to allow for distributions of Spark 3 that install the binary this way. See also apache/airflow#30065. * Fix lint errors in spark.rst and test_spark_submit.py
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 21, 2023
As discussed in apache#30064 - the security vulnerabilty fix from the apache#27646 restricted the spark binaries a little too much (the binaries should be restricted only when passed via extra). This PR fixes it, spark submit is only restricted when passed via extra, you can still pass any binary via Hook parameter.
eladkal
pushed a commit
that referenced
this pull request
Mar 22, 2023
As discussed in #30064 - the security vulnerabilty fix from the #27646 restricted the spark binaries a little too much (the binaries should be restricted only when passed via extra). This PR fixes it, spark submit is only restricted when passed via extra, you can still pass any binary via Hook parameter.
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 12, 2023
* Add spark3-submit to list of allowed spark-binary values The list of allowed values for spark-binary was restricted in apache/airflow#27646. Add spark3-submit to this list to allow for distributions of Spark 3 that install the binary this way. See also apache/airflow#30065. * Fix lint errors in spark.rst and test_spark_submit.py GitOrigin-RevId: b3259877fac7330d2b65ca7f96fcfc27243582d6
ahidalgob
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2023
* Add spark3-submit to list of allowed spark-binary values The list of allowed values for spark-binary was restricted in apache/airflow#27646. Add spark3-submit to this list to allow for distributions of Spark 3 that install the binary this way. See also apache/airflow#30065. * Fix lint errors in spark.rst and test_spark_submit.py GitOrigin-RevId: b3259877fac7330d2b65ca7f96fcfc27243582d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.