GH-40343: [C++] Move S3FileSystem to the registry #41559
+229
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
Component: Documentation
awaiting committer review
bkietz
force-pushed
the
40343-s3fs-into-registry
branch
from
589e7d7
to
9cc73fc
Compare
bkietz
force-pushed
the
40343-s3fs-into-registry
branch
from
9cc73fc
to
7c7a277
Compare
bkietz
force-pushed
the
40343-s3fs-into-registry
branch
from
7c7a277
to
970eaa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Moving S3 to a separate module will allow separate build and installation of that capability.
What changes are included in this PR?
[x] a factory for S3 filesystems is added to the registry
[ ] S3 options are completely covered by URI parameters
Are these changes tested?
Yes, the FromURI functionality is tested.
Are there any user-facing changes?
No