[BEAM-8567] Do not swallow execution errors during checkpointing #10008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unrelated Dataflow failures: |
tweise
approved these changes
Nov 6, 2019
tweise
reviewed
Nov 6, 2019
| invokeFinishBundle(); | ||
| } | ||
| outputManager.closeBuffer(); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Maybe also create a JIRA in Flink to have a cleaner way to signal an application error?
There was a problem hiding this comment.
Would make sense. Normally, there should be no application logic in here, though there are probably other people who have similar logic in snapshotState.
There was a problem hiding this comment.
|
Please also see #10007. |
dmvk
approved these changes
Nov 7, 2019
tweise
reviewed
Nov 8, 2019
| } | ||
| outputManager.closeBuffer(); | ||
| } catch (Exception e) { | ||
| // Any regular exception during checkpointing will be tolerated by Flink because those |
There was a problem hiding this comment.
Suggested change
| // Any regular exception during checkpointing will be tolerated by Flink because those | |
| // https://jira.apache.org/jira/browse/FLINK-14653 | |
| // Any regular exception during checkpointing will be tolerated by Flink because those |
mxm
changed the title
If a bundle fails to finalize before creating a checkpoint, it may be swallowed and just considered a checkpointing error. This breaks the execution flow and exactly-once guarantees.
|
Run Portable_Python PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a bundle fails to finalize before creating a checkpoint, it may be swallowed
and just considered a checkpointing error. This breaks the execution flow and
exactly-once guarantees.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.