[BEAM-7029] Add KafkaIO.Write as an external transform #8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python PreCommit |
mxm
commented
Apr 17, 2019
|
Planning to merge this later today if there are no further comments. |
|
We should allow the user to specify the environment for the external transform. Would like to be able to use EMBEDDED when using the Flink runner. |
|
I already discovered this before opening this PR and created https://jira.apache.org/jira/browse/BEAM-7084. I think this can be solved independently of this PR. |
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
Outdated
Show resolved
Hide resolved
chamikaramj
reviewed
Apr 25, 2019
| self.assertTrue('No resolvable bootstrap urls given in bootstrap.servers' | ||
| in str(ctx.exception), | ||
| 'Expected to fail due to invalid bootstrap.servers, but ' | ||
| 'failed due to:\n%s' % str(ctx.exception)) | ||
|
|
||
| # We just test the expansion but do not execute. |
This adds KafkaIO.Write as an external transform and includes a Python wrapper (WriteToKafka) for convenience.
|
Thanks for all the comments! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds KafkaIO.Write as an external transform and includes a Python
wrapper (WriteToKafka) for convenience.
CC @chamikaramj @ihji @robertwb @tweise
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.