Fix peers v2 system table behaviour when 2 nodes swap their IP Addresses #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beobal
approved these changes
Apr 18, 2024
| logger.debug("Purging {} from system.peers_v2 table", addresses); | ||
| QueryProcessor.executeInternal(String.format(peers_delete_query, SYSTEM_KEYSPACE_NAME, PEERS_V2), addresses.broadcastAddress.getAddress(), addresses.broadcastAddress.getPort()); | ||
| QueryProcessor.executeInternal(String.format(legacy_peers_delete_query, SYSTEM_KEYSPACE_NAME, LEGACY_PEERS), addresses.broadcastAddress.getAddress()); | ||
| removeFromLegacyPeerTable(addresses.broadcastAddress); |
There was a problem hiding this comment.
can also replace the calls on lines 171-173 below
| @@ -197,4 +195,11 @@ else if (NodeState.isPreJoin(next.directory.peerState(nodeId))) | |||
| tokens); | |||
| } | |||
| } | |||
|
|
|||
| public static void removeFromLegacyPeerTable(InetAddressAndPort addr) | |||
There was a problem hiding this comment.
nit: IMO this name is slightly confusing because we execute not only legacy_peers_delete_query but also peers_delete_query. I know that both those tables are "legacy" in the sense that ClusterMetadata.directory is the primary datasource now, but I'd either rename the method to removeFromSystemPeersTables or rename the queries to peers_delete_query / peers_v2_delete_query
There was a problem hiding this comment.
Good point. Renamed to removeFromLegacyPeerTable.
Throw if node id has been changed and does not match directory. If, however the _ip_ address has changed, issue Startup and correct the IP address. Disallow picking over identity of other nodes via hijacking their IPs or via overriding local node id with theirs. Patch by Alex Petrov; reviewed by TBD for CASSANDRA-19221
ifesdjeen
force-pushed
the
CASSANDRA-19221
branch
from
fc41825
to
e086615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw if node id has been changed and does not match directory. If, however the ip address has changed, issue Startup and correct the IP address. Disallow picking over identity of other nodes via hijacking their IPs or via overriding local node id with theirs.