CASSANDRA-19577 Make queries visible to the "system_views.queries" virtual table at the coordinator level #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedhroz
force-pushed
the
CASSANDRA-19577-4.1
branch
from
dd84ff1
to
71b87c2
Compare
dcapwell
approved these changes
Apr 29, 2024
Comment on lines
97
to
95
| return withResources.isNoOp() ? newTask(callable(runnable)) | ||
| : newTask(withResources, callable(runnable)); | ||
| } |
There was a problem hiding this comment.
is there a reason to keep this logic and guard the above logic with if (runnable instanceof RunnableDebuggableTask)? As far as I can tell there isn't a good reason... we convert the runnable to callable for the execution logic, and the debug logic deals with the raw type...
There was a problem hiding this comment.
It certainly doesn't fail any tests to simplify this...
test/distributed/org/apache/cassandra/distributed/test/QueriesTableTest.java
Outdated
Show resolved
Hide resolved
test/distributed/org/apache/cassandra/distributed/test/QueriesTableTest.java
Outdated
Show resolved
Hide resolved
…he coordinator level patch by Caleb Rackliffe; reviewed by David Capwell for CASSANDRA-19577
maedhroz
force-pushed
the
CASSANDRA-19577-4.1
branch
from
71b87c2
to
9b18324
Compare
|
Committed as 428fa1f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Caleb Rackliffe; reviewed by Chris Lohfink for CASSANDRA-19577