Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-329: (android) Fixes issue: Exif data lost on many cases #331

Merged
merged 2 commits into from Feb 21, 2019
Merged

GH-329: (android) Fixes issue: Exif data lost on many cases #331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bf22af
GH-329 android: Fix Exif data lost when correctOrientation is true
AlvaroHerrero Aug 26, 2018
beab392
Changed variable name
AlvaroHerrero Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/android/CameraLauncher.java
View file
Open in desktop
Expand Up @@ -994,6 +994,7 @@ private Bitmap getScaledAndRotatedBitmap(String imageUrl) throws IOException {
// read exifData of source
exifData = new ExifHelper();
exifData.createInFile(filePath);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT to your PR, but man is this a bad variable file. I read it as "create in file", but it actually means "create in(put)file".

exifData.readExifData();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't really understand how reading some data into a property/class variable of exifData influences the further execution of code. Can you explain?

// Use ExifInterface to pull rotation information
if (this.correctOrientation) {
ExifInterface exif = new ExifInterface(filePath);
Expand Down