[incubator-kie-issues#1104] Migrate Junit inside DMN #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariofusco
approved these changes
May 6, 2024
baldimir
approved these changes
May 6, 2024
…1104 # Conflicts: # kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNCompilerTest.java # kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/DMNTypeTest.java
yesamer
reviewed
May 6, 2024
| testRoundTrip("org/kie/dmn/backend/marshalling/v1_1/", "dish-decision.xml"); | ||
| } | ||
|
|
||
| @Ignore("failing to compare over a xsi:type=\"tImport\" attribute, but why content generated 'control' need to explicit it ?") | ||
| @Disabled("failing to compare over a xsi:type=\"tImport\" attribute, but why content generated 'control' need to explicit it ?") |
There was a problem hiding this comment.
Unrelated to this change...But I'm wondering if makes sense to create a new ticket that requires to review of all the disabled tests we have and decide if they deserve a fix or if they should be removed, WDYT?
| @Test | ||
| public void testTest() throws ScriptException { |
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
May 7, 2024
* [incubator-kie-issues#1104] Moved to junit 6 /jupiter * [incubator-kie-issues#1104] Fix formatting * [incubator-kie-issues#1104] Fix formatting * [incubator-kie-issues#1104] Fix merge. BAn junit 4 from kie-dmn modules * [incubator-kie-issues#1104] Fix format - attempt * [incubator-kie-issues#1104] Fix xml format --------- Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#1104
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdbfor Jenkins PR check only
Build Nowbutton.