This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Move InstawebHandler initialization after validity checks. #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating an instaweb handler will run MakeRequestUrl, which assumes that request->unparsed_uri is non-null. So move the creation to after where we check that it's non-null. To be safe, move it all the way down to where it's first needed, in case some other validity checks end up being relevant. Fixes #1248
|
Makes sense, LGTM |
|
Merged as befa494 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating an instaweb handler will run MakeRequestUrl, which assumes that
request->unparsed_uri is non-null. So move the creation to after where
we check that it's non-null. To be safe, move it all the way down to
where it's first needed, in case some other validity checks end up being
relevant.
Fixes #1248