fix(6509): improve the test case coverage of saga module to 70% #6519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xjlgod You can submit your PR in stages. |
I am trying to invoke codecov action to see my test case coverage by add new commit. But I find the error is It seems that the quota limit has been reached. |
… into feature/2.x-saga-test # Conflicts: # saga/seata-saga-spring/src/test/java/org/apache/seata/saga/engine/tm/DefaultSagaTransactionalTemplateTest.java # saga/seata-saga-spring/src/test/java/org/apache/seata/saga/engine/tm/MockGlobalTransaction.java
xjlgod
changed the title
| import java.util.Map; | ||
|
|
||
| /** | ||
| * @author jingliu_xiong@foxmail.com |
There was a problem hiding this comment.
delete the author infomation,as well as below
xjlgod
force-pushed
the
feature/2.x-saga-test
branch
from
723a505
to
77cd034
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6519 +/- ##
============================================
+ Coverage 50.02% 51.57% +1.55%
- Complexity 5224 5597 +373
============================================
Files 950 1005 +55
Lines 33447 34749 +1302
Branches 4047 4138 +91
============================================
+ Hits 16732 17922 +1190
+ Misses 15104 15033 -71
- Partials 1611 1794 +183 |
xjlgod
changed the title
funky-eyes
reviewed
May 27, 2024
lightClouds917
suggested changes
Jun 5, 2024
changes/zh-cn/2.x.md
Outdated
| @@ -155,6 +155,7 @@ | |||
| - [[#6456](https://github.com/apache/incubator-seata/pull/6456)] 调整动态配置监听测试用例 | |||
| - [[#6466](https://github.com/apache/incubator-seata/pull/6466)] 支持redis的集成测试 | |||
| - [[#6484](https://github.com/apache/incubator-seata/pull/6484)] 修复FileConfigurationTest和MockServerTest失败 | |||
| - [[#6519](https://github.com/apache/incubator-seata/pull/6484)] 增加saga模块的测试用例覆盖率 | |||
| public void testCreateExpression() { | ||
| SpringELExpressionFactory factory = new SpringELExpressionFactory(null); | ||
| factory.createExpression("'Hello World'.concat('!')"); | ||
| } |
There was a problem hiding this comment.
need assert result,not only call method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix #6509
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews