New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the UnifiedHighlighter's hasUnrecognizedQuery function processes FunctionQuery the same way as MatchAllDocsQuery and MatchNoDocsQuery queries for performance reasons. #13165
Open
vletard
wants to merge
10
commits into
apache:main
Choose a base branch
from
vletard:functionquery-as-unrecognizedquery-in-unifiedhighlighter
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dc1db92
Made the UnifiedHighlighter's hasUnrecognizedQuery function processes…
ljak 270dcf8
tidy-ed
5b64e21
Added test for "no effect queries" compliancy in UnifiedHighlighter.
vletard c16bd20
Merge remote-tracking branch 'laurent/functionquery-as-unrecognizedqu…
vletard f7f529b
Including term vectors strategy in test.
vletard 684a94c
Recognized Query classes extracted into a static Set.
vletard e2a961a
Included MatchNoDocsQuery in UH offset strategy check.
vletard 8801851
tidy-ed
vletard 7565f70
Moved ignorable query test to its own method.
vletard 908ac35
Added UH extensibility test.
vletard File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test to TestUnifiedHighlighterExtensibility that checks that overrides to
isIgnorableQuery
work here as well? I think it will, but to be perfectly honest I can never remember the inheritance rules around class-specificthis
calls...