MASSEMBLY-617 : add ability to set fileMappers in FileSet in maven as…

[tcollignon]

…sembly plugin

new version of PR #4 for https://issues.apache.org/jira/browse/MASSEMBLY-617

[tcollignon]

Hi

This need certainly to add test but I don't know where :(

And in MDO it"s wrong in version and again I don't know what i must do in it

Thx

[spiritualops]

Don't use SNAPSHOTs, please.

[spiritualops]

Please don't use SNAPSHOT versions, as this could introduce instability at any given time.

[tcollignon]

Hi @spiritualops , yes of course, I'm just waiting plexus release (maybe it's already done) to change this with the correct release version

And I need help to maybe add some test, and for MDO

Thx

[plamentotev]

The Plexus Archiver has been released and the assembly plugin is already updated to use a newer version so you can just rebase your branch.

[plamentotev]

You can't use the FileMapper from Plexus IO directly. You need to declare all types (except "simple" types such as String) in the MDO. So you have to declare this type in MDO as well and then use it to configure the actual FileMappers.

[plamentotev]

@tcollignon I've added comment about the MDO inline. hope it helps but if its too vague I'll try to find some time to add an example.

About the tests take a look at src/it/projects/file-sets - those are the integration tests for the file sets. One of those should be suitable to add file matter and then verify it. If not you can use one as base to crate a new one. Also it may be worth to check if src/test/java/org/apache/maven/plugins/assembly/archive/task/AddFileSetsTaskTest.java and src/test/java/org/apache/maven/plugins/assembly/archive/phase/FileSetAssemblyPhaseTest.java need to be updated.

[tcollignon]

thx for your answer @plamentotev , I will try to finish this when I can

[tcollignon]

So @plamentotev I have try to do something.
Can you tell my what you think please?
I'm not very comfortable with MDO, I'm sorry.
I have added a large amount of code in AddDirectoryTask, and I think it's not very good with the beautiful il else ..., if you have better please tell me

[tcollignon]

Note : This PR could close https://issues.apache.org/jira/browse/MASSEMBLY-886 too

[tcollignon]

Hi any news here?
@plamentotev Can you look at this please?

thx for your time

[plamentotev]

Hi @tcollignon,

The problem is not that much with the verbosity of the code, but that is the list of file mappers is practically hard coded. If you want to add another one you'll need to change the AddDirectoryTask as well. You can get a FileMapper instance from Plexus using its role so you can avoid hard coding the instances. The bigger problem is how to configure them. Unfortunately the interface does not contain means to configure them so the only option is through reflection. You can take a look how Archiver is configured - org.apache.maven.plugins.assembly.archive.DefaultAssemblyArchiver#configureArchiver. You need something similar for MDO, but I'm not too familiar with it myself. I guess you can add field of type DOM that can contain arbitrary XML so you can use it to configure the FileMapper instances.