[Pulsar admin] admin command 'get-message-by-id' can get message by messageId regardless of topic name

[zhanghaou]

[leizhiyuan]

which version do you use？

[zhanghaou]

which version do you use？

2.8.0

[leizhiyuan]

now ,It seems topic only for validate the ledgerId has the topic and some auth etc.

when validate success, invoke the ledger to fetch message, there is no check after find the message with id.

if topic1 and topic2 was putted into same leager , this will be not right.

[leizhiyuan]

maybe what we need is to clear the description.

because in get-message-by-id , you know ledgerId and entryId, what topic belongs of the message is very clear.

[gaozhangmin]

topic is useless in this command, Maybe we should remove it.

[leizhiyuan]

topic is useless in this command, Maybe we should remove it.

but now It has some prechecks, but when checking done,when query message, topic name has no meaning.. I think it is confused sometimes.

[zhanghaou]

topic is useless in this command, Maybe we should remove it.

Topic is useful for lookup, and can redirect to the owner broker for finding the managedLedger. But even if we get the wrong managedLedger, we can use the managedLedger to get the message. Maybe we can add createIfMissing in the method 'getLedgerHandle'.

[zhanghaou]

if topic1 and topic2 was putted into same leager , this will be not right.

Does messages from different topics can put into same ledger?

[gaozhangmin]

Does messages from different topics can put into same ledger?

No。

[zhanghaou]

@zhanghaou
thank you for sharing this finding.

this bug looks like a security issue.
please take into consideration to file a "Security report" for the next time.
This issue is disclosing a potential security risk to a wide audience.

the correct process is to send an email to security@apache.org or to private@pulsar.apache.org

we will follow up with a release soon

OK.