[Issue 11814] fix pulsar admin method:getMessageById. #11852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
reviewed
Aug 31, 2021
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
|
Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks) |
This is bug fix, no need to add docs. |
sijie
approved these changes
Sep 2, 2021
sijie
added
area/admin
release/2.7.4
release/2.8.2
type/bug
eolivelli
reviewed
Sep 2, 2021
| + "the ledgerId does not belong to this topic.", | ||
| clientAppId(), ledgerId, entryId, topicName); | ||
| asyncResponse.resume(new RestException(Status.NOT_FOUND, | ||
| "Message not found, the ledgerId does not belong to this topic")); |
There was a problem hiding this comment.
We should add a 'return' here
Let me send a fix up patch
eolivelli
pushed a commit
to eolivelli/pulsar
that referenced
this pull request
Sep 2, 2021
Fix apache#11814 , if we use another topic to find the message, it will return the message, but we may contaminate the ledgers cache in the topic. **changes** Add check in the method 'internalGetMessageById' in PersistentTopicsBase, if the ledgerId not belong to this topic, throw a exception. (cherry picked from commit 9bfb3db)
eolivelli
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 2, 2021
Fix apache#11814 , if we use another topic to find the message, it will return the message, but we may contaminate the ledgers cache in the topic. **changes** Add check in the method 'internalGetMessageById' in PersistentTopicsBase, if the ledgerId not belong to this topic, throw a exception. (cherry picked from commit 9bfb3db)
hangc0276
pushed a commit
that referenced
this pull request
Sep 3, 2021
Fix #11814 , if we use another topic to find the message, it will return the message, but we may contaminate the ledgers cache in the topic. **changes** Add check in the method 'internalGetMessageById' in PersistentTopicsBase, if the ledgerId not belong to this topic, throw a exception. (cherry picked from commit 9bfb3db)
This was referenced Sep 3, 2021
|
Remove the release/2.7.4 label, #11913 already fixed the branch-2.7 |
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Fix apache#11814 , if we use another topic to find the message, it will return the message, but we may contaminate the ledgers cache in the topic. **changes** Add check in the method 'internalGetMessageById' in PersistentTopicsBase, if the ledgerId not belong to this topic, throw a exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11814 , if we use another topic to find the message, it will return the message, but we may contaminate the ledgers cache in the topic.
changes
Add check in the method 'internalGetMessageById' in PersistentTopicsBase, if the ledgerId not belong to this topic, throw a exception.