PIP-41 (part-1): Introduce Protocol Handler API #5130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Motivation* This is the first pull request for implementing PIP-41. PIP-41: https://github.com/apache/pulsar/wiki/PIP-41%3A-Pluggable-Protocol-Handler *Modification* - Introduce the protocol handler API - Introduce a new field `protocols` in LoadReport - Add util classes to search and load protocol handlers - Include the protocol handlers in broker's lifecycle - Add settings to configure what protocol handlers to load
sijie
added
type/feature
sijie
requested review from
ivankelly,
merlimat,
rdhabalia,
jiazhai,
codelipenghui and
wolfstudy
|
Tests are coming in the next commit. |
jiazhai
approved these changes
Sep 8, 2019
codelipenghui
approved these changes
Sep 9, 2019
|
I have added the unit tests for newly introduced classes. |
|
run integration tests |
|
@merlimat can you take a look at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the first pull request for implementing PIP-41.
PIP-41: https://github.com/apache/pulsar/wiki/PIP-41%3A-Pluggable-Protocol-Handler
Modification
protocolsin LoadReport