New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIP-44] Separate schema compatibility checker for producer and consumer #5227
Conversation
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
@congbobo184 isn't #5165 already doing the same thing? |
# Conflicts: # pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/AvroReader.java
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
run cpp tests |
I see you introduced two settings, one is the flag to control auto update and the other flag is to set the compatibility check strategy. These two settings are fine. I am just wondering how are we going to do with the existing auto update schema strategy. Are we going to deprecated the existing one? |
@sijie if user set the auto update strategy by new way, we will use the new setting, otherwise will use old setting. So this change can read the old setting, if user update the auto update strategy by new way and then update it by the old way(May be a different version of the broker), new change will be ignored. |
run Integration Tests |
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
ping @sijie PTAL |
@codelipenghui @congbobo184 can you please update the schema documentation to reflect to this change? @Anonymitaet can help review the content, since she has written all the schema documentation for Pulsar. |
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java
run java8 tests |
@congbobo184 @codelipenghui can you guys add documentation about this? /cc @jennifer88huang @Anonymitaet for this. Make sure the documentation for this feature goes in before we release 2.5.0. |
OK, I will add the documentation about this. :) |
@congbobo184 can you create a github issue for that? |
Got it. |
Master Issue: #4737
Motivation
Implement of PIP-44.
Modifications
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (yes)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (yes)
Anything that affects deployment: (no)
Documentation
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation