Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-48048][CONNECT][SS] Added client side listener support for Scala #46287

Closed
wants to merge 5 commits into from

Conversation

bogao007
Copy link
Contributor

What changes were proposed in this pull request?

Added client side Streaming Listener support for Scala

Why are the changes needed?

Support Streaming Listener on client side for Spark Connect which has better user experience (no breaking change compared to legacy mode) compared to previous server side listener.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added unit test.

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Contributor

@WweiL WweiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments

@bogao007 bogao007 changed the title [SPARK-48048] Added client side listener support for Scala [SPARK-48048][CONNECT] Added client side listener support for Scala May 1, 2024
Copy link
Contributor

@WweiL WweiL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogao007 bogao007 changed the title [SPARK-48048][CONNECT] Added client side listener support for Scala [SPARK-48048][CONNECT][SS] Added client side listener support for Scala May 1, 2024
@HyukjinKwon
Copy link
Member

Merged to master.

JacobZheng0927 pushed a commit to JacobZheng0927/spark that referenced this pull request May 11, 2024
### What changes were proposed in this pull request?

Added client side Streaming Listener support for Scala

### Why are the changes needed?

Support Streaming Listener on client side for Spark Connect which has better user experience (no breaking change compared to legacy mode) compared to previous server side listener.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Added unit test.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#46287 from bogao007/client-listener.

Authored-by: bogao007 <bo.gao@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants