[SPARK-48062][PYTHON][SS][TESTS] Add pyspark test for SimpleDataSourceStreamingReader #46306
+76
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
reviewed
May 1, 2024
| @@ -136,6 +137,33 @@ def streamWriter(self, schema, overwrite): | |||
|
|
|||
| return TestDataSource | |||
|
|
|||
| def _get_simple_data_source(self): | |||
There was a problem hiding this comment.
Maybe just define this class and directly pass SimpleDataSource to register?
HyukjinKwon
reviewed
May 1, 2024
| while len(q.recentProgress) < 10: | ||
| time.sleep(0.2) | ||
| q.stop() | ||
| q.awaitTermination |
HyukjinKwon
reviewed
May 1, 2024
| q.stop() | ||
| q.awaitTermination | ||
| self.assertIsNone(q.exception(), "No exception has to be propagated.") | ||
|
|
||
| def test_stream_writer(self): | ||
| input_dir = tempfile.TemporaryDirectory(prefix="test_data_stream_write_input") |
There was a problem hiding this comment.
let's add cleanup
input_dir.cleanup()
output_dir.cleanup()
checkpoint_dir.cleanup()those into finally. Feel free to do it in a separate PR.
HyukjinKwon
reviewed
May 1, 2024
| q.stop() | ||
| q.awaitTermination | ||
| self.assertIsNone(q.exception(), "No exception has to be propagated.") | ||
|
|
||
| def test_stream_writer(self): | ||
| input_dir = tempfile.TemporaryDirectory(prefix="test_data_stream_write_input") | ||
| output_dir = tempfile.TemporaryDirectory(prefix="test_data_stream_write_output") |
There was a problem hiding this comment.
class PythonStreamingDataSourceTests(BasePythonStreamingDataSourceTestsMixin, ReusedSQLTestCase):
...
has to be
class PythonStreamingDataSourceTests(BasePythonStreamingDataSourceTestsMixin, ReusedSQLTestCase):
pass
because ... basically means to omit (and to be defined/implemented laster).
HyukjinKwon
changed the title
HyukjinKwon
approved these changes
May 1, 2024
allisonwang-db
approved these changes
May 1, 2024
|
Merged to master. |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…eStreamingReader ### What changes were proposed in this pull request? Add pyspark test for SimpleDataSourceStreamingReader. ### Why are the changes needed? To make sure SimpleDataSourceStreamingReader works end to end. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Test change. Also trigger python_streaming_datasource and python_parity_streaming_datasource locally. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#46306 from chaoqin-li1123/test_simple_reader. Authored-by: Chaoqin Li <chaoqin.li@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
reviewed
May 22, 2024
| @@ -150,50 +151,90 @@ def check_batch(df, batch_id): | |||
| q.awaitTermination | |||
There was a problem hiding this comment.
@chaoqin-li1123 can we fix all those instances?
There was a problem hiding this comment.
Could you elaborate? is this test flaky?
There was a problem hiding this comment.
Thanks for reminding!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add pyspark test for SimpleDataSourceStreamingReader.
Why are the changes needed?
To make sure SimpleDataSourceStreamingReader works end to end.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test change. Also trigger python_streaming_datasource and python_parity_streaming_datasource locally.
Was this patch authored or co-authored using generative AI tooling?
No.