[SPARK-47671][Core] Enable structured logging in log4j2.properties.template and update docs #46349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dtenedor @panbingkun as well. |
|
|
||
| To implement structured logging, start with the `log4j2.properties.template` file. | ||
|
|
||
| ## Plain Text Logging |
There was a problem hiding this comment.
Thank you for providing this section together.
|
@dongjoon-hyun I double checked and removed some comments. PTAL, thanks! |
dongjoon-hyun
approved these changes
May 3, 2024
|
Thank you. Merged to master, @gengliangwang ! |
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…mplate and update docs ### What changes were proposed in this pull request? - Rename the current log4j2.properties.template as log4j2.properties.pattern-layout-template - Enable structured logging in log4j2.properties.template - Update `configuration.md` on how to configure logging ### Why are the changes needed? Providing a structured logging template and document how to configure loggings in Spark 4.0.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Manual test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46349 from gengliangwang/logTemplate. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
configuration.mdon how to configure loggingWhy are the changes needed?
Providing a structured logging template and document how to configure loggings in Spark 4.0.0
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual test
Was this patch authored or co-authored using generative AI tooling?
No