Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5271 Fix appveyor-ci:configuring incomplete #2227

Closed
wants to merge 1 commit into from
Closed

THRIFT-5271 Fix appveyor-ci:configuring incomplete #2227

wants to merge 1 commit into from

Conversation

zeshuai007
Copy link
Member

@zeshuai007 zeshuai007 commented Sep 3, 2020 •
edited

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@zeshuai007 zeshuai007 marked this pull request as ready for review September 3, 2020 08:31
@zeshuai007 zeshuai007 changed the title Fix appveyor-ci:configuring incomplete THRIFT-5271 Fix appveyor-ci:configuring incomplete Sep 3, 2020
ulidtko
ulidtko approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@ulidtko ulidtko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a workaround until they fix the Chocolatey package and release a version that actually works.

@zeshuai007
Copy link
Member Author

I found it fixed itself.

@zeshuai007 zeshuai007 closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulidtko ulidtko ulidtko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zeshuai007 @ulidtko