[ZOOKEEPER-4831] update slf4j from 1.x to 2.0.13, logback to 1.3.14 #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhangJian He <shoothzj@gmail.com>
ctubbsii
suggested changes
May 3, 2024
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigExceptionTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
|
@ctubbsii Thanks for your review. Fixed.
definitely. |
|
@eolivelli @maoling @tisonkun PTAL, can we merge this into master branch |
eolivelli
approved these changes
May 9, 2024
tisonkun
approved these changes
May 9, 2024
|
Thanks for your contribution! |
|
ping @eolivelli @maoling @tisonkun |
|
Merged thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update slf4j to 2.x, logback to 1.3.14. This is a backward-compatible change.
slf4j
SLF4J API version 2.0.0 requires Java 8 and introduces a backward-compatible fluent logging API. By backward-compatible, we mean that existing logging frameworks do not have to be changed in order for the user to benefit from the fluent logging API.
logback
Version 1.3.x supports Java EE, while version 1.4.x supports Jakarta EE. The two versions are feature identical.
Both 1.3.x and 1.4.x series require SLF4J 2.0.x or later.
The 1.3.x series requires Java 8 at runtime.