Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost attributes with surrogate main #6019

Closed

Conversation

rbonatuvic
Copy link

@rbonatuvic rbonatuvic commented Apr 24, 2024

When the surrogate feature is enabled, the SurrogatePrincipalElectionStrategy is used instead of DefaultPrincipalElectionStrategy.
SPES selects attributes that are 'attached' to the principal, in comparison to DPES, which selects the merged collection of attributes from all principals.
When authentication flow involves more than one authentication method, with resulting multiple principals each having different attribute sets, SPES will select an attribute set from only one of the principals.
e.g., ldap authn with ldap attributes, duo MFA with duo attributes; only the duo attributes are included in the nominated principal.

This change adds a surrogate specific principal which is checked by SPES when selecting attributes. Only if the principal is a surrogate will the surrogate's attributes be returned. Otherwise behaviour is as in DPES.

  • Brief description of changes applied
  • Test cases for all modified changes, where applicable
  • The same pull request targeted at the master branch, if applicable
  • [NA] Any documentation on how to configure, test
  • [nil] Any possible limitations, side effects, etc
  • [none] Reference any other pull requests that might be related

Copy link

github-actions bot commented May 1, 2024

This pull request has been open and inactive. It will be closed shortly.

@github-actions github-actions bot added the Stale label May 1, 2024
@github-actions github-actions bot closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants