-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check validity of exercise points after admitting deadline deviation or extra attempts #892
Comments
Did some editing and moved modification problem into separate issue #902 |
It was noted in a meeting today, that re-adjusting points, e.g. removal of late penalties, can be done without needing to rerun the grading process. |
Issue 694 in EDIT Jira |
Do you mean that this already can be done in the system or that this is another idea for the future implementation? I don't think we currently have a well-automated feature for this use case. It is possible to manually assess submissions or manually send them to auto-regrading, but that is too time-consuming for the teacher. The idea was that if the student has already made submissions, but they did not get points either due to the late penalty (requires that late submissions are allowed) or becoming an unofficial submission (requires that unofficial submissions are enabled in the category), then either
I like 2) because:
|
With poor phrasing I think I intended to mean the same as (2) |
Relevant comment from the duplicate issue: #482 (comment) The old discussion copied to the issue description mentions personal deadline extensions, but on the other hand, it seems unnecessary to create any deadline extensions when the submission already exists in the database. Deadline extensions should only be used when we want the student to submit again after the deadline. Another idea:
|
Juha confirmed that he likes option (2). Juha emphasized the following needs. It should be possible to convert a student's late submissions to graded submissions (i) for a whole module at once, and (ii) for individual assignments. The teacher makes this operation for a single student at a time. It is not necessary to select multiple students at once. The teacher's UI: the teacher should be able to access this feature in the course participant page (one student's view when you click a single student in the course participants list) AND in the inspect submission page (which shows a single submission, but the feature would still affect the student's all submissions in that assignment). |
Notes from a meeting with teachers on 23.2.2022. Included in the first pull requestInspect view:
Included in the second pull requestIn the add deviations feature:
Ideas that should be considered in the endUndo feature:
|
I assume "first pull request" above means revised version of #991 , second and possibly third will be separate PRs. |
Yes, that is what I meant. |
Course staff may approve late and/or unofficial submissions so that any point penalties are removed from those submissions and they become normal, graded submissions (with the "ready" status). Single submissions may be approved or all submissions from one student in one assignment or one whole course module. The whole assignment or module approval may also be set to target only late submissions or only unofficial submissions. The user interface for this feature is visible in the inspect submission view when inspecting a late or unofficial submission. Part of apluslms#892. "The first pull request" in the comment: apluslms#892 (comment) Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
Fixes apluslms#892. "The second pull request" in the comment: apluslms#892 (comment) Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
Course staff may approve late and/or unofficial submissions so that any point penalties are removed from those submissions and they become normal, graded submissions (with the "ready" status). Single submissions may be approved or all submissions from one student in one assignment or one whole course module. The whole assignment or module approval may also be set to target only late submissions or only unofficial submissions. The user interface for this feature is visible in the inspect submission view when inspecting a late or unofficial submission. Part of apluslms#892. "The first pull request" in the comment: apluslms#892 (comment) This work started in Muhammad's pull request apluslms#991. Markku has refactored the code, improved the database queries and the details overall. Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
Fixes apluslms#892. "The second pull request" in the comment: apluslms#892 (comment) Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
Course staff may approve late and/or unofficial submissions so that any point penalties are removed from those submissions and they become normal, graded submissions (with the "ready" status). Single submissions may be approved or all submissions from one student in one assignment or one whole course module. The whole assignment or module approval may also be set to target only late submissions or only unofficial submissions. The user interface for this feature is visible in the inspect submission view when inspecting a late or unofficial submission. Part of apluslms#892. "The first pull request" in the comment: apluslms#892 (comment) This work started in Muhammad's pull request apluslms#991. Markku has refactored the code, improved the database queries and the details overall. Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
Fixes apluslms#892. "The second pull request" in the comment: apluslms#892 (comment) Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
Course staff may approve late and/or unofficial submissions so that any point penalties are removed from those submissions and they become normal, graded submissions (with the "ready" status). Single submissions may be approved or all submissions from one student in one assignment or one whole course module. The whole assignment or module approval may also be set to target only late submissions or only unofficial submissions. The user interface for this feature is visible in the inspect submission view when inspecting a late or unofficial submission. Part of #892. "The first pull request" in the comment: #892 (comment) This work started in Muhammad's pull request #991. Markku has refactored the code, improved the database queries and the details overall. Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
TODO: * +1 max submissions deviation button in the inspect submission view: should this also check if any submission should be approved immediately? * test all the changes * deviations/viewbase.py approve_unofficial_submissions(): implementation unfinished * clean up the code * success messages to the user in the user interface? When deviations are added, the teacher may choose to also immediately approve such existing submissions that are covered by the deviation. For example, if the submission was late, but with the new personal deadline it is not late, then it would be approved. Fixes apluslms#892. "The second pull request" in the comment: apluslms#892 (comment) This work started in Muhammad's pull request apluslms#991. Markku has refactored the code, improved the database queries and the details overall. Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
The merged commit 7c65106 implements the basic submission approval in the inspect view: a single submission or all submissions in one assignment or module. Approving when adding deviations is part of the unfinished draft pull request #1029. The pull request #991 was closed because it had too many issues. |
Course staff may approve late and/or unofficial submissions so that any point penalties are removed from those submissions and they become normal, graded submissions (with the "ready" status). Single submissions may be approved or all submissions from one student in one assignment or one whole course module. The whole assignment or module approval may also be set to target only late submissions or only unofficial submissions. The user interface for this feature is visible in the inspect submission view when inspecting a late or unofficial submission. Part of apluslms#892. "The first pull request" in the comment: apluslms#892 (comment) This work started in Muhammad's pull request apluslms#991. Markku has refactored the code, improved the database queries and the details overall. Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
When student is admitted deadline extension, the exercise points for already submitted tasks should be checked and updated automatically. Currently this requires manual clicking.
Also, if student is given extra attempts, exercise points should be checked for submissions that exceeded the previous limit.
The text was updated successfully, but these errors were encountered: