Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approve late/unofficial submissions when adding deviations #1029

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markkuriekkinen
Copy link
Collaborator

Work-in-progress draft as a reminder: Approve late/unofficial submissions when adding deviations

TODO:

  • +1 max submissions deviation button in the inspect submission view:
    should this also check if any submission should be approved immediately?
  • test all the changes
  • deviations/viewbase.py approve_unofficial_submissions(): implementation unfinished
  • clean up the code
  • success messages to the user in the user interface?

When deviations are added, the teacher may choose to also immediately
approve such existing submissions that are covered by the deviation.
For example, if the submission was late, but with the new personal
deadline it is not late, then it would be approved.

Fixes #892.
"The second pull request" in the comment:
#892 (comment)

This work started in Muhammad's pull request #991. Markku has
refactored the code, improved the database queries and the details
overall.

Co-authored-by: Muhammad Wahjoe faiz00.muhammad@gmail.com

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

markkuriekkinen and others added 2 commits May 6, 2022 15:47
TODO:
* +1 max submissions deviation button in the inspect submission view:
  should this also check if any submission should be approved
  immediately?
* test all the changes
* deviations/viewbase.py approve_unofficial_submissions():
  implementation unfinished
* clean up the code
* success messages to the user in the user interface?

When deviations are added, the teacher may choose to also immediately
approve such existing submissions that are covered by the deviation.
For example, if the submission was late, but with the new personal
deadline it is not late, then it would be approved.

Fixes apluslms#892.
"The second pull request" in the comment:
apluslms#892 (comment)

This work started in Muhammad's pull request apluslms#991. Markku has
refactored the code, improved the database queries and the details
overall.

Co-authored-by: Muhammad Wahjoe <faiz00.muhammad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check validity of exercise points after admitting deadline deviation or extra attempts
1 participant