Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide module model answers on lifesupport #1330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mikael-Lenander
Copy link
Contributor

Description

What?

Now also chapters that are marked as model answers for a module are hidden after the lifesupport time passes.

Why?

Model answers should be hidden after the course ends.

Should the message in the info tooltip inside a hidden chapter MODULE_MODEL_ANSWER_NOT_VISIBLE also be changed accordingly? Now it only says: "This chapter is hidden, since it contains model answers that have not been published yet." even if the course is ended.

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Student wasn't able to see model chapters after setting lifesupport time to a past date.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@murhum1
Copy link
Contributor

murhum1 commented Jun 7, 2024

I had to rework the way the visibility is checked due to the larger cache rework that was made earlier, but kept the added tests.

@murhum1 murhum1 requested review from ihalaij1 and removed request for murhum1 June 7, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants