Add submission tags #1358
Merged
Add submission tags #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelGusse
force-pushed
the
submission_tags
branch
2 times, most recently
from
35e04b1
to
b25bac7
Compare
- Increased padding - Implemented wrapping for tags - Changed dropdown appearance
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
murhum1
requested changes
May 14, 2024
There was a problem hiding this comment.
Thanks! I left comments on some things I think should be fixed before merging.
There's also some parts I'm not entirely sure about, and the whole thing with saving submission taggings by creating on-demand forms in JS, but we can take a look at that later if need be since this implementation does work.
mikaelGusse
force-pushed
the
submission_tags
branch
from
3bc8271
to
145a783
Compare
Submission tags are created through the inspect submission UI so the form is unnecessary, as well as the associated template. Also checked submission tagging add- and delete forms to verify the tag comes from the accessed course instance.
murhum1
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What?
Added tags to submissions and the possibility to filter using these tags.
submission_tags_demo_compressed_1.mp4
Why?
Adds a requested feature that allows teachers to more easily identify particular submissions.
How?
Added a new django model for the submissiontag and additionally a submissiontagging class which stores which submissiontags belong to which submissions. Additionally added javascript table manipulation for filtering.
Fixes #1347
Testing
Remember to add or update unit tests for new features and changes.
What type of test did you run?
Tested adding tags to multiple submissions and creating new tags. Also tried filtering with different combinations of tags.
Did you test the changes in
Think of what is affected by these changes and could become broken
Translation
Programming style
Have you updated the README or other relevant documentation?
Is it Done?
Clean up your git commit history before submitting the pull request!