[ops]: add warning for custom APPSMITH_GIT_ROOT #33355
Conversation
WalkthroughWalkthroughThe recent update includes warnings in both the Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedBiome (20)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9031756843. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
deploy/docker/fs/opt/appsmith/run-with-env.sh (1)
34-34: Ensure the deprecation warning forAPPSMITH_GIT_ROOTis clear and actionable.Consider adding more details about the deprecation timeline or alternative configurations to the warning message. This will help users understand the urgency and the necessary steps they should take.
|
Deploy-Preview-URL: https://ce-33355.dp.appsmith.com |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (4)
deploy/docker/fs/opt/appsmith/utils/bin/backup.js (4)
Line range hint
17-17: Use strict equality checks.Replace
==with===and!=with!==to avoid potential bugs due to type coercion in JavaScript.- if (encryptionPassword == -1){ + if (encryptionPassword === -1){ - if (gitRoot != "/appsmith-stacks/git-storage/"){ + if (gitRoot !== "/appsmith-stacks/git-storage/"){Also applies to: 47-47, 137-137
Line range hint
58-58: Use template literals for string operations.Replace string concatenations with template literals for improved readability and consistency with modern JavaScript practices.
- logger.backup_info('Finished creating an encrypted a backup archive at ' + encryptedArchivePath); + logger.backup_info(`Finished creating an encrypted a backup archive at ${encryptedArchivePath}`); - const archive = Constants.BACKUP_PATH + '/appsmith-backup-' + timestamp + '.tar.gz'; + const archive = `${Constants.BACKUP_PATH}/appsmith-backup-${timestamp}.tar.gz`;Also applies to: 64-64, 73-73, 102-102, 150-150, 158-159, 161-161, 186-186, 192-192, 208-208
Line range hint
1-1: Use thenode:protocol for importing built-in modules.To ensure compatibility with future versions of Node.js and to explicitly differentiate built-in modules from third-party ones, prepend
node:to the module names.- const fsPromises = require('fs/promises'); + const fsPromises = require('node:fs/promises'); - const path = require('path'); + const path = require('node:path'); - const os = require('os'); + const os = require('node:os'); - const tty = require('tty'); + const tty = require('node:tty');Also applies to: 2-2, 3-3, 9-9
Line range hint
21-26: Convert function expressions to arrow functions.For consistency with modern JavaScript practices, convert the anonymous function expression to an arrow function.
- shell.exec(check_supervisord_status_cmd, function (code) { + shell.exec(check_supervisord_status_cmd, (code) => {
No description provided.