Formatting #16
Merged
Formatting #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting changes to better follow recommended/common ways to format Swift. For example avoid ";" and "()" when not needed, usage of "self" when not needed for clarity, and some other things. Also removes some redundant whitespace/new-lines.
|
LGTM, thank you 馃槉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting changes to better follow recommended/common ways to format Swift. For example avoid ";" and "()" when not needed, usage of "self" when not needed for clarity, and some other things.
Also removes some redundant whitespace/new-lines.
If one wants to there are ways to setup automatic formatting using various tools (such as swift-format, SwiftFormat, SwiftLint, etc.). That can be for another PR though.
For this PR I have just made some basic changes that are (usually 馃槄) not controversial, but of course if there are any objections to the style I can change.