Cleanup/sut checker modules #20880
Open
Cleanup/sut checker modules #20880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a way to scan test infrastructure for commandline options and their defaults - move most options out of `testing.js` into the modules that work with these options - options used by instance.js and instance-manager.js will end in instance-manager.js - introduce API function to add documentation including duplicate checking - remove redundand options from testsuites - locate and fix duplicates - move portManager into its own file
naushniki
approved these changes
May 7, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
|
|
||
| for (var attrname in functionsDocumentation) { fnDocs[attrname] = functionsDocumentation[attrname]; } | ||
| for (var i = 0; i < optionsDocumentation.length; i++) { optionsDoc.push(optionsDocumentation[i]); } | ||
| tu.CopyIntoObject(fnDocs, functionsDocumentation); |
There was a problem hiding this comment.
the call to CopyIntoList is missing...
jsteemann
reviewed
May 24, 2024
| @@ -292,6 +292,5 @@ exports.setup = function (testFns, opts, fnDocs, optionsDoc, allTestPaths) { | |||
| testFns['BackupAuthSysTests'] = BackupAuthSysTests; | |||
| testFns['BackupAuthNoSysTests'] = BackupAuthNoSysTests; | |||
|
|
|||
| for (var attrname in functionsDocumentation) { fnDocs[attrname] = functionsDocumentation[attrname]; } | |||
| for (var i = 0; i < optionsDocumentation.length; i++) { optionsDoc.push(optionsDocumentation[i]); } | |||
| tu.CopyIntoObject(fnDocs, functionsDocumentation); | |||
There was a problem hiding this comment.
the call to CopyIntoList is missing...
jsteemann
reviewed
May 24, 2024
js/client/modules/@arangodb/testutils/sutcheckers/collections.js
Outdated
Show resolved
Hide resolved
jsteemann
reviewed
May 24, 2024
js/client/modules/@arangodb/testutils/sutcheckers/collections.js
Outdated
Show resolved
Hide resolved
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
jsteemann
reviewed
May 24, 2024
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
…s.js Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
Co-authored-by: Jan <jsteemann@users.noreply.github.com>
…ions. Do away with cut'n' paste leftovers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
make SUT health checkers modular.