Saving additional info zone helper #3388
Conversation
There was a problem hiding this comment.
I tested the script on a small residential area in Singapore Woodlands. The changes worked as intended, and the corresponding columns appeared in the Input Editor. The contents of the columns also made sense; only three of the buildings were missing an address - the first corresponded to a small shelter and the other two to an electrical substation. So all of that makes sense.
The only open question in my opinion is the one regarding the string-to-float conversion.
There was a problem hiding this comment.
Most of the changes look good to be. The only question I have is about the removal of the string-to-float conversion for some of the parameters (lines 75-80): What's the reasoning behind removing that section?
There was a problem hiding this comment.
Thanks for this.
Please see my comments below.
| selected_columns = list(set(list_of_columns).intersection(set(OSM_COLUMNS))) | ||
| shapefile[selected_columns] = shapefile[selected_columns] \ | ||
| .fillna(1).apply(lambda x: pd.to_numeric(x, errors='coerce')) | ||
|
|
There was a problem hiding this comment.
@MatNif
Correct me if I am wrong. The original Line 75-80 and Line 81-85 are duplicated. Hence, I removed the Line75-80
There was a problem hiding this comment.
Sorry, I think you're right. I missed that.
In that case, I think this PR is good to go.
In addition to the internal CEA handle of
Building Name, such as B1000, and B1001, this PR updates zone_helper to save additional information, includinghouse number,street name,house_name,postal code, city,residential_type(to indicate Singapore's HDB),city, andcountry.