Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argo-cd): Fix typo of policy.csv comment in values.yaml #1136

Merged
merged 2 commits into from Feb 17, 2022

Conversation

KENNYSOFT
Copy link
Contributor

@KENNYSOFT KENNYSOFT commented Feb 17, 2022

Question:

Since it's extra-small PR and only fixes the comment, would I still have to update the chart version or changelog?


Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

Signed-off-by: Hyeonmin Park <hyeonmin.park@kennysoft.kr>
@KENNYSOFT KENNYSOFT force-pushed the argo-cd-fix-typo branch 2 times, most recently from 7cb331c to c139995 Compare February 17, 2022 04:52
@KENNYSOFT KENNYSOFT changed the title chore(argo-cd): Fix typo in values.yaml chore(argo-cd): Fix typo of policy.csv comment in values.yaml Feb 17, 2022
@mkilchhofer
Copy link
Member

Since it's extra-small PR and only fixes the comment, would I still have to update the chart version or changelog?

Unfortunately yes, otherwise our pipeline (required) is not green.

@KENNYSOFT
Copy link
Contributor Author

KENNYSOFT commented Feb 17, 2022

Since it's extra-small PR and only fixes the comment, would I still have to update the chart version or changelog?

Unfortunately yes, otherwise our pipeline (required) is not green.

I see. I've asked since it's hard to know before any contributor approves the workflow run; will do it.

@mbevc1
Copy link
Collaborator

mbevc1 commented Feb 17, 2022

Thanks for your contribution @KENNYSOFT 👍 . Could you also please update your branch with master?

@KENNYSOFT
Copy link
Contributor Author

Thanks for your contribution @KENNYSOFT 👍 . Could you also please update your branch with master?

Sure, thanks for the guide. I saw other PRs are squashed, so I think updating with merge or rebase is both available options. I'll take the former.

@mbevc1 mbevc1 merged commit 591de85 into argoproj:master Feb 17, 2022
terrych0u pushed a commit to terrych0u/argo-helm that referenced this pull request Aug 4, 2022
…oj#1136)

Signed-off-by: Hyeonmin Park <hyeonmin.park@kennysoft.kr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants