Merge pull request #13572 from artsy/DIA-380-logged-out-users-sees-si…

…gn-in-prompt-on-works-for-you feat(works-for-you): includes login prompt when logged out
artsy · Mar 5, 2024 · d8dab0a · d8dab0a
2 parents 47083d0 + 5fbd125
commit d8dab0a
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 13 deletions.
diff --git a/src/Apps/NewForYou/Components/NewForYouArtworksGrid.tsx b/src/Apps/NewForYou/Components/NewForYouArtworksGrid.tsx
@@ -20,7 +20,7 @@ export const NewForYouArtworksGrid: FC<NewForYouArtworksGridProps> = ({
           columnCount={[2, 3, 4]}
         />
       ) : (
-        <Text variant="lg" mt={4} color="black60">
+        <Text variant="lg-display" mt={4} color="black60">
           Nothing yet.
         </Text>
       )}

diff --git a/src/Apps/WorksForYou/WorksForYouApp.tsx b/src/Apps/WorksForYou/WorksForYouApp.tsx
@@ -18,6 +18,9 @@ import { WorksForYouArtistFeedPaginationContainer } from "./Components/WorksForY
 import { useRouter } from "System/Router/useRouter"
 import { extractNodes } from "Utils/extractNodes"
 import { RouterLink } from "System/Router/RouterLink"
+import { LogInPrompt } from "Apps/Components/LogInPrompt"
+import { AuthContextModule, ContextModule } from "@artsy/cohesion"
+import { useSystemContext } from "System/SystemContext"
 
 interface WorksForYouProps {
   viewerArtist: WorksForYouApp_viewerArtist$data
@@ -30,6 +33,8 @@ const WorksForYouApp: React.FC<WorksForYouProps> = ({
   viewerFeed,
   viewerMe,
 }) => {
+  const { isLoggedIn } = useSystemContext()
+
   const { router } = useRouter()
 
   const followedArtists = extractNodes(
@@ -63,16 +68,27 @@ const WorksForYouApp: React.FC<WorksForYouProps> = ({
 
       <Spacer y={2} />
 
+      <LogInPrompt
+        contextModule={
+          ContextModule.recommendedWorksForYouRail as AuthContextModule
+        }
+      />
+
       {savedArtworks.length === 0 ? (
         <>
-          <Text variant="lg-display">Nothing yet.</Text>
-          <Text variant="lg-display" color="black60" mt={1}>
-            Follow{" "}
-            <RouterLink color="black60" to="/artists">
-              some artists
-            </RouterLink>
-            .
+          <Text variant="lg-display" color="black60">
+            Nothing yet.
           </Text>
+
+          {isLoggedIn && (
+            <Text variant="lg-display" color="black60" mt={1}>
+              Follow{" "}
+              <RouterLink color="black60" to="/artists">
+                some artists
+              </RouterLink>
+              .
+            </Text>
+          )}
         </>
       ) : (
         <GridColumns>

diff --git a/src/Apps/WorksForYou/worksForYouRoutes.tsx b/src/Apps/WorksForYou/worksForYouRoutes.tsx
@@ -13,11 +13,6 @@ export const worksForYouRoutes: AppRouteConfig[] = [
   {
     path: "/works-for-you/:artistSlug?",
     getComponent: () => WorksForYouApp,
-    onServerSideRender: ({ req, res }) => {
-      if (!req.user) {
-        res.redirect("/")
-      }
-    },
     onClientSideRender: () => {
       WorksForYouApp.preload()
     },