New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove existing user check from inquiry auth flow #13605
Conversation
@@ -12,9 +12,6 @@ export const formatErrorMessage = (error: Error) => { | |||
case "User Already Exists": | |||
return "An account with this email already exists." | |||
|
|||
case "User Not Found": | |||
return "No account with this email exists." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks very reasonable. I appreciate the detail and the clear before/after screenshots.
Assigning this PR to myself. Realized I need to push integrity changes. Will sequence the rollout once those are ready. |
The type of this PR is: Refactor
This PR solves PHIRE-670
Description
This PR removes the existing user check from the inquiry flow. See the parent of the ticket above for more detailed reasoning.
In slack, redirecting to the canonical auth flow was discussed as an option. I decided against this for the following reasons:
Considerations