Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collectorprofile): roughs in artists page #13644

Merged
merged 1 commit into from Mar 28, 2024
Merged

feat(collectorprofile): roughs in artists page #13644

merged 1 commit into from Mar 28, 2024

Conversation

dzucconi
Copy link
Member

@dzucconi dzucconi commented Mar 27, 2024 •
edited

Closes DIA-535

@dzucconi dzucconi requested a review from a team March 27, 2024 13:55
@dzucconi dzucconi self-assigned this Mar 27, 2024
dzucconi
dzucconi commented Mar 27, 2024
View reviewed changes
src/Apps/CollectorProfile/collectorProfileRoutes.tsx
@@ -131,6 +141,13 @@ export const collectorProfileRoutes: AppRouteConfig[] = [
}
`,
children: [
{
path: "artists",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The route should be: /collector-profile/artists, not /collector-profile/my-collection/artists, to match the other routes.

araujobarret
araujobarret previously approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@araujobarret araujobarret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know sounds tedious to write unit test for a simple fragment like this, but that's the way we should work, with unit tests 😜

@dzucconi dzucconi force-pushed the DIA-535-create-new-route-for-collector-profile-my-collection-artists branch from 30e157f to ba358f7 Compare March 28, 2024 12:00
@dzucconi dzucconi enabled auto-merge March 28, 2024 12:00
@dzucconi dzucconi merged commit 863f716 into main Mar 28, 2024
11 checks passed
@dzucconi dzucconi deleted the DIA-535-create-new-route-for-collector-profile-my-collection-artists branch March 28, 2024 12:09
@artsy-peril artsy-peril bot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@araujobarret araujobarret araujobarret left review comments

Assignees

@dzucconi dzucconi

Labels
Jira Synced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dzucconi @araujobarret