Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add non bnmo purchases to CollectorResume buyerActivity #5621

Merged
merged 4 commits into from Mar 15, 2024
Merged

feat: add non bnmo purchases to CollectorResume buyerActivity #5621

merged 4 commits into from Mar 15, 2024

Conversation

egdbear
Copy link
Contributor

@egdbear egdbear commented Mar 13, 2024 •
edited by jira bot

This PR addresses the calculation of non-BNMO purchases and combines them with BNMO purchases from Exchange.

Please find related Gravity PR here.

DIA-503

@egdbear egdbear force-pushed the egdbear/feature/add-nonbnmo-purchases-counts branch from d7d6be6 to 8893eff Compare March 13, 2024 16:14
@egdbear egdbear requested a review from a team March 13, 2024 16:17
@egdbear egdbear changed the title [DRAFT] feat: add non bnmo purchases to CollectorResume buyerActivity feat: add non bnmo purchases to CollectorResume buyerActivity Mar 13, 2024
@egdbear egdbear self-assigned this Mar 13, 2024
@egdbear egdbear requested a review from dzucconi March 13, 2024 18:30
@egdbear egdbear force-pushed the egdbear/feature/add-nonbnmo-purchases-counts branch from b5c87d4 to 7bb319d Compare March 15, 2024 09:41
iskounen
iskounen previously approved these changes Mar 15, 2024
View reviewed changes
dzucconi
dzucconi previously approved these changes Mar 15, 2024
View reviewed changes
dzucconi
dzucconi reviewed Mar 15, 2024
View reviewed changes
src/lib/stitching/exchange/v2/stitching.ts Outdated
error
)

return { totalPurchases: null }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this return 0?

@egdbear egdbear dismissed stale reviews from dzucconi and iskounen via 662bdaf March 15, 2024 16:06
@egdbear egdbear merged commit bea796d into main Mar 15, 2024
4 checks passed
@egdbear egdbear deleted the egdbear/feature/add-nonbnmo-purchases-counts branch March 15, 2024 16:18
@artsy-peril artsy-peril bot mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzucconi dzucconi dzucconi left review comments

@iskounen iskounen iskounen left review comments

Assignees

@egdbear egdbear

Labels
Jira Synced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@egdbear @dzucconi @iskounen