Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gateway allowed headers and allowed methods in config template #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carabasdaniel
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9030181442

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 22.752%

Files with Coverage Reduction New Missed Lines %
pkg/cli/cc/ports.go 6 76.27%
Totals Coverage Status
Change from base Build 9006413483: -0.1%
Covered Lines: 1126
Relevant Lines: 4949

💛 - Coveralls

@carabasdaniel carabasdaniel marked this pull request as ready for review May 14, 2024 09:23
Comment on lines +159 to +163
- "PATCH"
- "PROFIND"
- "MKCOL"
- "COPY"
- "MOVE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't expose any endpoints that respond to these methods, do we? Why allow them by default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked to expose ALL settings that are by default set by the service-host, as it is not clear what disappears when you set just one. Ideally service-host, would not set any defaults but only provide the means to set them, in which case the service needs to set/define what it needs based on its usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants