Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new dark theme. #147

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

noor-2002
Copy link

I added a new Black and yellow theme which looks awesome. I just wanted to share my theme.

NOTE :
-- I did come changes in text color for some pages. (ex : in accordion)
--Please check my example for reference.

Here is my portfolio example : https://noormohamed.netlify.app/#/home

@ashutosh1919
Copy link
Owner

@NoorMohamed-intern , The theme looks good but there are some discrepancies.

  • The hair of the illustration is not observable because of the black color
  • The shirt of illustration is not observable because of black color.

@noor-2002
Copy link
Author

@NoorMohamed-intern , The theme looks good but there are some discrepancies.

  • The hair of the illustration is not observable because of the black color
  • The shirt of illustration is not observable because of black color.

Yes, i noticed there are some inconsistencies in some pages and needed to changed manually. Do you have any idea to make it work smoothly?

@ashutosh1919
Copy link
Owner

@NoorMohamed-intern , may be you can try changing the color of person's har to be little bit different or may be you can change the background color to be little bit lighter. You can experiment with it and submit whichever you feel is more elegant.

The bg color has changed bit lighter. For the illustration to pop-up.
@noor-2002
Copy link
Author

noor-2002 commented Sep 15, 2021

@NoorMohamed-intern , may be you can try changing the color of person's har to be little bit different or may be you can change the background color to be little bit lighter. You can experiment with it and submit whichever you feel is more elegant.

Yes, i changed it for my site. But how can a new user, change it (hair color/shirt color) from theme.js without changing it from source, ?

@ashutosh1919
Copy link
Owner

@NoorMohamed-intern , As of now you can't change some internal colors (hair, face etc) from theme but you can change shirt, pants etc.

@noor-2002
Copy link
Author

@ashutosh1919 Okay, for now i changed background color to be bit lighter.

@saiteja13427
Copy link
Collaborator

saiteja13427 commented Jun 9, 2022

@NoorMohamed-intern This looks quite good but I think we should further lighten the background colour a bit.

Issues
Hair is still not clearly visible
The name on splash screen is also not visible properly
The menu bar on phone is not visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants