InvokeAsync(StateHasChanged) from StateHasChanged() #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
JialinXin
reviewed
Aug 29, 2023
| @@ -40,12 +49,18 @@ else | |||
| else | |||
| { | |||
| <div class="@item.CSS"> | |||
| @if (!string.IsNullOrWhiteSpace(item.RecieverUsername)) | |||
There was a problem hiding this comment.
Add From and To for easy understand and optimize order like below?
<div class="user">From: @item.Username</div>
@if (!string.IsNullOrWhiteSpace(item.RecieverUsername))
{
<div class="user">To: @item.RecieverUsername</div>
}
<div class="msg">@item.Body</div>| { | ||
| _connectedUsers = userList.ToList(); | ||
| InvokeAsync(StateHasChanged); | ||
| //StateHasChanged(); |
| <div class="user">@item.Username</div> | ||
| <div class="msg">@item.Body</div> | ||
| </div> | ||
| } | ||
| } | ||
| <hr /> | ||
| <label for="recipientUsername">Send message to:</label> |
There was a problem hiding this comment.
Add a <div> to wrap this Send section, so won't break the rendering.
<div id="sendto">
<label for="recipientUsername">Send message to:</label>
<input type="text" id="recipientUsername" @bind="_recipientUsername" />
</div>| @@ -8,22 +11,42 @@ namespace BlazorChat | |||
| public class BlazorChatSampleHub : Hub | |||
| { | |||
| public const string HubUrl = "/chat"; | |||
| private static ConcurrentDictionary<string, string> _connectedUsers = new ConcurrentDictionary<string, string>(); | |||
There was a problem hiding this comment.
How about cache Dictionary<UserName, List>()? As always fetch by userId.
|
|
||
| public async Task Broadcast(string username, string message) | ||
| { | ||
| await Clients.All.SendAsync("Broadcast", username, message); | ||
| } | ||
| public async Task SendUserToUser(string senderUsername, string recipientUsername, string message) | ||
| { | ||
| var recipientConnectionId = _connectedUsers.FirstOrDefault(u => u.Value == recipientUsername).Key; |
There was a problem hiding this comment.
Cache by userId as key so you don't need to find by value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser was not getting changes promptly. It was getting changes one event late. e.g. if user clicks send button, then it would get pending message from other users and it would still not show the message that was sent by itself which would be shown only after another action from the user.
This correction is taken from https://learn.microsoft.com/en-us/aspnet/signalr/overview/getting-started/tutorial-server-broadcast-with-signalr.